----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193336 -----------------------------------------------------------
Ship it! Master (47c6899) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 9, 2017, 10:13 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64482/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2017, 10:13 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > I opted for a minimal patch that stays close to the style of the other > tests. There is a remaining risk of a race condition if the OS re-uses > the same port between stopping jetty and triggering the webhooks, but > it should be very unlikely. > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > adeff8939a4c4a225444dc5ca2575f9eb705a92b > > > Diff: https://reviews.apache.org/r/64482/diff/2/ > > > Testing > ------- > > Multiple runs of ./gradlew test > > > Thanks, > > Stephan Erb > >
