-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193341
-----------------------------------------------------------



@ReviewBot retry

- John Sirois


On Dec. 9, 2017, 9:32 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2017, 9:32 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
> 
> Included changes:
> 
> * Update to the latest pants version. This was necesary to get ./pants gen 
> working.
> * The Java hashcode option has been removed as it is now the default.
> 
> 
> Diffs
> -----
> 
>   .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde 
>   3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> 835b0cc6f51a592f7d5b6129dbe9519455eb6555 
>   api/src/main/thrift/org/apache/thermos/BUILD 
> b58338e76bdee3481071d8f27235a9dbb6bf07b5 
>   build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 
>   build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac 
>   build-support/python/checkstyle-check 
> 0c8800232e20347b2be9a538ffed1d47a7815241 
>   build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 
>   build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 
>   build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae 
>   build-support/release/make-python-sdists 
> 51e11dbc1929609374031c9b23a96f035eba902b 
>   build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> 77c966caa3d1f644241bcc2b1968bc9306c56689 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  42300b43a8f72e45c96b975e5d3a6a7bd0283529 
>   build-support/thrift/AURORA-1727.lib.py.setup.py.patch 
> 11c7b13341e156f3686511cb40ab13c1256203a6 
>   build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 
>   build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 
>   build-support/thrift/prepare_binary.sh 
> 4ad997bf039294f7940b93a76ebf014689f8f618 
>   build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 
>   build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 
>   buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 
> fc2bc9082dae2c63aa578c05dc89feb346260a67 
>   pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 80a6dec9acf5b64cff64143929916676b79be686 
>   src/main/python/apache/thermos/observer/BUILD 
> 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 
>   src/test/python/apache/aurora/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/admin/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/client/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/client/api/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/client/binding_helpers/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/client/cli/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/client/docker/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/common/health_check/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/aurora/executor/common/__init__.py 
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd 
>   src/test/python/apache/thermos/core/test_process.py 
> 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 
> 
> 
> Diff: https://reviews.apache.org/r/64290/diff/4/
> 
> 
> Testing
> -------
> 
> ```
> $ ./build-support/jenkins/build.sh
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to