----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64625/ -----------------------------------------------------------
Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. Repository: aurora Description ------- This tool was originally intended as a migration path between Persistence backends. As it turns out, the model also works well for recovering from a backup. I propose we drop our current recovery mechanism to use this tool. The existing recovery-via-scheduler-rpc is slightly non-sensical, as it assumes a healthy scheduler. When an operator decides it is necessary to recover from a backup, we should assume the scheduler state may be broken. Furthermore, starting an empty scheduler to bootstrap can have undesirable effects such as advertising false state to clients and establishing a new empty framework with the master. Diffs ----- build.gradle 46745132fcbe9d089833461b82b92e01c2156235 config/checkstyle/suppressions.xml c4081b9ee3cd46725dd06c0bac9aef75e08c7429 src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 4f99f80d11481e79e487c4b1fb378cebd7c3456b src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 2bf7e7ba414d36c99a49599fdc8cf3abdc945dc9 src/main/java/org/apache/aurora/scheduler/config/CliOptions.java b7f43e0d6efbddcac640c3d39c7bc56400e68e68 src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryBindings.java b574c1372db6a01e648f818798f8a86ba45faf06 src/main/java/org/apache/aurora/scheduler/storage/backup/BackupReader.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 79899a078218c75c61ed6b0b9be5096dd19c55a1 src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 0305d9d8858076b27a5931ea53b761551276a75b src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorageModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/durability/Recovery.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistenceModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 671593c539f8c42437e752def7c0e0f57bc553c2 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotModule.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5aefe5fc2cc5c1695c8e5fb62abfa41a377dfd6e src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 4929ecdec90a1ccbcafa4857dea83cec1e2d7fd4 src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 53a2315bd9e70742bae3b15332482ca452d67576 src/test/java/org/apache/aurora/scheduler/storage/durability/RecoveryTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogPersistenceTest.java 3d6d5552e5a719ca0fd8cf3739b44a90c415f36c src/test/java/org/apache/aurora/scheduler/storage/log/NonVolatileStorageTest.java fdde73d009f66019f1be93d8f812571be3a2c584 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotServiceTest.java 270453d16d7bc03285ccc7d9602b59a07bd3b24c src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 2ad4e843be1cd98f460f09d22877f77447cfa2b4 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1500bda8844316e0fcff0534a9f9bb9b5cdaea5f Diff: https://reviews.apache.org/r/64625/diff/1/ Testing ------- end-to-end tests pass (and exercise recovery tool) Thanks, Bill Farner
