-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64629/#review193946
-----------------------------------------------------------


Ship it!




Ship It!

- Jordan Ly


On Dec. 14, 2017, 11:09 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64629/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2017, 11:09 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The only functional changes encountered were changes from 
> `IllegalStateException` to `NoSuchElementException` when calling 
> `Optional#get()`.  We used this behavior, though exclusively in tests.
> 
> You might find it easier to review this by downloading and viewing with 
> git-diff, though reviewboard seems to render it fine.
> 
> 
> Diffs
> -----
> 
>   
> commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java
>  e40f327de0b746436a62a6ebc3fe767ad2c02ddd 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> af1a7b337647066a40fbf65cef8d39cf94f38da4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> c02dd384f71a52fcf80c6af992a3e5ad3517c00c 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 0c31c4a1ab7b6dd5551fc6d37de7410224de647f 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 
> c70f108fabb79250881a3b1519c09451f870ab93 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> d83a11f6029ddbd44f903258d3a523f6fc28d815 
>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
> aa09aff5fc65352111223abfc2425e8e066b9383 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> 1aacecf3c2597a3f91dbc7da4c99fd1e80970f04 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 3911626e57f483ee6a5cd11538a0c07200c344aa 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
> 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> e1f20f43f9b0a9da91af54d2af95946418b8884e 
>   
> src/main/java/org/apache/aurora/scheduler/config/converters/DataAmountConverter.java
>  a0d262023d61a8d4c6a16564e9342e0b2b8d39aa 
>   
> src/main/java/org/apache/aurora/scheduler/config/converters/TimeAmountConverter.java
>  7e66cf203130f947b0e57683da0aae3845f7d5ae 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  f3e98f2a25fb72a9d5f0a5f953287b5b0b16dd10 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  af289130c3f58c78de27dd8ef614d70ae57f3ef3 
>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
> 8957b3a04e681c653884fdc9134d74ae766677ae 
>   src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 
> ac45f1544f0713d10b7bb6a8d44a1f3f3bd980c6 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 
> 6e56867c838aa4b43d242ee314baf767d4d9a815 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> 87970f6c4139a6391be88a91661500e6cc7bf101 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> d890cad95ad9e851a3ac685f6de1be5754809a98 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 90399f22c50ba3218fa3f392c3dbf24e6ea524a1 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
> e937667dc73c432dc0934a18f28274913ec5640d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 
> ead85c34fe6c8cc9d93329bf5d6e4595a044f201 
>   
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>  48c7bfd85a5365426f47010ec61b16c72b86bf78 
>   src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
> 1a7e8cb420ed46c4d0eb543ecca8e1056e207eb8 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 73fcdd0a7b3476a26c5383edbfef522aa65f4435 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
> 44789d62232d8723878b98717ae8a967aa270a7e 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> b0a9081aead12cc4f3a63dbf8fd2f2a271c7f993 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
> d4099c28e411a0fd81c11b5d32585a6473240fba 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 82a7a1625a99fee9c8b36dfc029dec1646d61e1d 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 41a07646a92332a977039cf98570180ef19a3bcc 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 9a0314068c66b6a0a48fb761e1fcae31be28d1be 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
> 41bed3e49de935ba4c288641196c100db49d2d1e 
>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 
> 8b8b3051a7e7c5f67dd15e7b90692fee3ea46289 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> c1ff654ae6a6a49e27c6df1ac058b1a0cedeff08 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 399203bba5088adfa3d418ff8ac5339b2d0aa94e 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8826d25035ead144b3abd02c05223cb8367af0cb 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetter.java 
> b2ca0122d72303fc6f052b59a0ae21ea75810040 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetters.java 
> a833672cd13db7ab6d35a5bb621e6d591b9dea12 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  fc4c3ec7b445c275137f7b7b12795d96223a0dd4 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  8da06a01a379c0c0ebbda6e1f19dadf8018caa8d 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  203599ef90c3714ffc8dfcbf54155db77b4dd7be 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java
>  2b7621a775a4c6c8a3e2059e61df97c06ef8a60d 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ThriftFieldGetter.java
>  0b64d1a5bbab5ee4f9b150bb50580e86529918e0 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 
> bcdd459a4a3fea1b39c923b0c94f771768a3aed9 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  bcfb8881160459f4ca7fe7a1847ecfa7fc6b3a56 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverFactory.java 
> 88a12b8866bb1dfd9018e265a31ec08765bc74eb 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java 
> 2fc37e430d77ef083559676c1d15b6d70407cf77 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverSettings.java 
> 39c0144432abed5c9858d55205412e5e5418379f 
>   src/main/java/org/apache/aurora/scheduler/mesos/LibMesosLoadingModule.java 
> ec0727958e80e2319d03a2dfd74ad9c4bf71f483 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 
> c61af2ba0f55bf4e300c8b790b320741c7ef4dec 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 727be588b13ebe18a0f6c23b03b26e87ca393609 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> e0221f8df0312c65e5403d6bfc37b76c21cc89bf 
>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedDriverFactory.java 
> 8afeec1220043a77e8844b082c6478356a89e65a 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl.java
>  5329de5aa6b639b82999ffc96751fed8549e82fd 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
>  46090642bf21819fccd232d1202a14f5534310a8 
>   src/main/java/org/apache/aurora/scheduler/offers/HostOffer.java 
> 79348387e3fc7a841426d809ce732d2dcbfa5b15 
>   src/main/java/org/apache/aurora/scheduler/offers/HostOffers.java 
> c0a4b5779105fb58ae0c8c3096894f3901fddfd0 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> df32775c43a5ea84cf1461ca39fa7e69f494e8ed 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManagerImpl.java 
> 14a528f1c7576446ed60ac8d39c023b150d234c3 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 
> 57462a30cef6cb4c4d4c91defc382fe0b5f2f2bc 
>   src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java 
> 76160124908826ff5e9d4cc980d9b1091163a671 
>   
> src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java 
> abfec58e961c8b0df059f99170f52dc6ebf8e40c 
>   
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java
>  cce93d89f0d6e33480d69c1410bf59f9519d2980 
>   src/main/java/org/apache/aurora/scheduler/preemptor/Preemptor.java 
> ffb8b907135033a9196236e33a13b9111a63751e 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorMetrics.java 
> 662aa2d5123e38b54faaa88268f88d4d410c95a3 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 5d8907a9f3eff89c3fd2ccb6d4bc3750de4c8d3b 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
> d3ca2df7cf4b45f0749647e8912cf5126ba38df6 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 64ad12bba338208f87f065d39ff526c006ef3079 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 
> 23ac714b442606e6f08165224f4bc4b07f17ee5c 
>   src/main/java/org/apache/aurora/scheduler/reconciliation/TaskTimeout.java 
> 9910e77fccdb1d0d6c5eb154a1a7773fe88bd809 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/FirstFitOfferSelector.java
>  1ccab2d79941f50ac14d3c262b490d1b840f856a 
>   src/main/java/org/apache/aurora/scheduler/scheduling/OfferSelector.java 
> a8b0cb88a7a5328c8721c95582196405119b0610 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  c0e877d78497d9fe0c26d2b8420a4b11b661d015 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskAssignerImpl.java 
> 31af277d4a2365b22852bf69e2001a58dfc0999a 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImpl.java 
> b6d5d95cb09aaccd2e1d15e3fdddf74d350c731f 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskThrottler.java 
> 24692b0e100efd04a6a3845747ff4089beb2e681 
>   src/main/java/org/apache/aurora/scheduler/spi/Permissions.java 
> 843621c455a0eed11e0784216a3756e9252271d9 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 1edb252035515e74f65eea424dbc9b5e94cae617 
>   src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java 
> 6d49c49b2bb2a26eddd4f0197288aa7dea87e0f6 
>   src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 
> 2aa500aed828a7627135b7498c752efbf3451270 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> b09787f6601980df5e6c0b4129fe193e83502f71 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 3ba676b81731079289937e4539f9c54db9fc7513 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 914d401206db8ccb8f4b624ddb0a8946c889b33d 
>   src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
> 95632b389664304238a6b9eb571f37f2205830ff 
>   src/main/java/org/apache/aurora/scheduler/storage/CronJobStore.java 
> d78474af5eff26fa9574347a4c4c7c2cbe50c0a7 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 6b91d970c90da91a590d0d71f5a995de27c38145 
>   src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 
> 688eb56c3073c73c271f3d2c80f356dae3f9c02b 
>   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
> c822e20becbc96e150d689cbbe65427d515b9db1 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> c9ea1deaf612920b799f30b624e3a7c7c243b771 
>   src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 
> 29d3b24fe7012dd659182b91fa353c52b98636a3 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java
>  5ae834abd066d59d97a1887e9cfa49a7c80d10b0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 5aefe5fc2cc5c1695c8e5fb62abfa41a377dfd6e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java 
> f1a5309e4a41996d1950a6380d8cf3397d266993 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 
> 3fd7d30b2d10e023a4cbea07e4cc479802b9d16a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java 
> f96ec08399ec0961f82487b038443973569f2b76 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 
> 61b9eeed22d7108893cd00ab183f571ffab32dd1 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
> 8a7ddd779e3af58983c6b67235ddc004b4e1d42d 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 3bef9b7de41f0cf41ff6dfa2a1e5ee0e68f010da 
>   src/main/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 
> f9d0bafbbfd0bd69db3ea94cb52a5b96c4870136 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java 
> d7bf846cced0df94c9fa909574c0ea69f4b286a8 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 9d327e4aebce80a734980f7b3d6e3d3f847caf5b 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  1b003ab6779b2b30418b92b01acac7aee6b8f6a0 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> 92107575615955fe0aabcfe23bdc82f0b3f837d0 
>   
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
> a39e871223dea06ad1a7ff2906d21c7a980c3bc4 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 
> 0aa4f36e92a02767c41f89a5239d64505fb9bf7f 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 9159d692fd520a58d352043abe97668209cb2330 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  87b18b4af2b21c41ecb1388f2b553ded90eb73b9 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 959a5a508c428151c5a9f5ec19ea5032b740898b 
>   src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java 
> 61d855e2d4aa62c8e8f67d838113134623c40182 
>   src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java 
> 06a7695af837b122d0e7b77b0d6393f106dd77f4 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateAgentReserver.java 
> fca4b4e7f292fb45e3721c7dabd65c8fa3f821e3 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
> b408a655be85cdd08149fa55ed8ee9311b71723d 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 56a6b0c9ae8da18e9a47428b8ed37a559cfd04e7 
>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
> b1d9f8ad480fbb6545c4b1aff7e3c655cda04249 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 4929ecdec90a1ccbcafa4857dea83cec1e2d7fd4 
>   src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 
> 63e84852405eaf5aa0d2e4ddab2a5cb89cc580fb 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 020f3484ea732c4b1b8aa5ee11b289727872925f 
>   src/test/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
> 7c7a950cd867f9ab465f790324b68f8ec6542de8 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
> 742a97cf4dc332c1645d27ce56c0f22affea0df3 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
>  439cf3eeb4e7a77be71f69e55a10f212d3a39cf2 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java
>  0f8c9839000e2e379a75fd9d10a7f22fc01f3b18 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java
>  f847882458ac12ec950ad9409a294b1e4c4377c9 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java 
> f1ea9e66831e4f6523a02674a5a399486de0907b 
>   
> src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java 
> 7496a70930c777ee55dd76221a3018c61830abdb 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  d2fe7a3d78c9c12ca3d0b40843eb7351217fe1fb 
>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 
> 1bd4440ecb19dd442fcb936596fa08c822d0e8b5 
>   src/test/java/org/apache/aurora/scheduler/http/MnameTest.java 
> c25264fef2f3e9a627a084685f5e019be14dbf71 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
> 62f569557477bd8e39dc4575e83b1f419b236e18 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
>  cda6ca2e846d011f1ded155b097d01ba90719b67 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ThriftFieldGetterTest.java
>  b0a8d750ffcbf072e373ed996feba63f5276feb3 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  a86184c34239b478255ba2e1201e47279801c12b 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 
> d79a973bac8a41476de23b4c911c65f05c5dda03 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java
>  be6e481f58d6c06e94ffd834a0b7aa5e8a637885 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java 
> abef3f0461c9d2f592da071e037e30c7525dfca6 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImplTest.java
>  8c259bfdd0ee19e8c13c7ef46d53e8022ef31185 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverServiceTest.java
>  a72bd4dd06114c136ee6e04a1bdf5a19d0af58ed 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> 75aedf5c8bbcea02aaa014d40b43131df39c6389 
>   src/test/java/org/apache/aurora/scheduler/preemptor/BiCacheTest.java 
> 4e27fbb74622ca1c5a47803730ddb9d2033a58c2 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
>  9ef55c86baedd934290a41902d8cde43f9b05656 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
>  40a5d4cd60dc4ee35547b39c73f1e099df5a3c0c 
>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java 
> 3d2c7fa73e889a1e62f73fb890925ad5d35dc4ff 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 815a3ef3cb567437e2741d0b96095c501197dd62 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> c1825f627ca6b384ad2ef21e9895da0b468bf42e 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
>  fb489ad5eb458428fd1408344a6d3a76b6b55e99 
>   
> src/test/java/org/apache/aurora/scheduler/reconciliation/TaskTimeoutTest.java 
> 71125bc414db2ec37eb1298d47b0c787cc603d1e 
>   src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 
> 468dcac5dc3b16ad425336710a52050b340bf0ad 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  e13fe7102261d3797ec14bf18630e8448f2958e6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 9739e9156783f72a69824a52a14ebf402b98e6ec 
>   
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskAssignerImplTest.java
>  a0e8634f24b4507ae51c3076f9a8904dc937f1a9 
>   
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java
>  260ff9d4eee020ab3359c696dac5d33bfe2ba465 
>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskThrottlerTest.java 
> 250161821b82491f97fc289e12df603ce6e226d8 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> 953b65f28a585375e36e305dea6f9f94f99abc93 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  0f1d4d493f56e9c3866b436d8e818676b1d0472b 
>   src/test/java/org/apache/aurora/scheduler/state/PartitionManagerTest.java 
> 8f654db1562480d36d963a9730c3f2d411e1065b 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 4cff10b0554ef666d27d4da5e91c76bf717d23f9 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> bb4e752b4aae0a01dbdaccf8b3412fa2cce63543 
>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
> 04350fa0c8946390adc19ac9b85b6da97c7f18e5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractAttributeStoreTest.java
>  1ad46806b9e9b10186cb79f286a1e33362638f8b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
>  3ec6e2bf28db20f1cda26dd9862af83d479ec4bf 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java
>  15108175ecfa62ea5bfe20d493ed92ed052f2536 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractQuotaStoreTest.java 
> c5aca7e7e4aa80545a92e405a3825381954372d9 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractSchedulerStoreTest.java
>  669b7c079d10f18b9992275d6857642bbc13d037 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 76595c03317122b2563cdb7a871bd39f37ccfbf5 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  a6bf330179de4349fe0d61ad00ed024e54894a3e 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/WriteRecorderTest.java
>  1a89e833e02c6fff3ca6bec7d4439d0ff699bd4c 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/NonVolatileStorageTest.java
>  fdde73d009f66019f1be93d8f812571be3a2c584 
>   
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
>  64fbb54ed587f1a2a8ac68c3e2cdeddddf39d1a3 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 
> d9e935cf6cfa69e3e38a5277ed44ea8b72baf1ae 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e1b8eaad178ddf8d73b89a977eb3ea80d101fd10 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  312e5e0261e7a5f57f04bcdb68440d2efddb0b97 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  040baf9b8fa51dbd7e41eab6ed6ce5957590aaeb 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 231fd8d0962c2ab8362634f2c2ea934148bc4532 
>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 
> 30f3e4f0c04669e1c0ebdc2bb0f4452f45c34e56 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 92f2582df8879ac1509f7055574dfc95518ef435 
>   src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 
> 61f66b9ff24ef667457b07939a6cd0def88e3fd9 
>   src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java 
> 32a8c89d3e71395696fc613da96b871330891c42 
> 
> 
> Diff: https://reviews.apache.org/r/64629/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to