----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64934/#review194725 -----------------------------------------------------------
Master (f1d9caf) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 3, 2018, 11:29 p.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64934/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 11:29 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Fixes the issue that caused the voting to fail for the 0.19.0 Aurora packages. > > Fix cribbed from: https://github.com/cbeust/jcommander/pull/422 > > Implemented as a custom converter as suggested here: > https://reviews.apache.org/r/64824/ > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/config/converters/StringListConverter.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 76ce39e837ea9dce81fdc66018611dfd11612388 > > > Diff: https://reviews.apache.org/r/64934/diff/1/ > > > Testing > ------- > > End to end. > Style check. > Integration. > Ran vagrant box, added `-thermos_executor_resources=""` created and killed a > job. > > > Thanks, > > Renan DelValle > >
