----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65234/#review195779 -----------------------------------------------------------
Ship it! Ship It! - Jordan Ly On Jan. 19, 2018, 3:54 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65234/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2018, 3:54 a.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Realized i never added this in the command line parser change. Note that > this output differs from the original code in one important way - it uses > `toString()` on the parameter type rather than printing the raw value from > the command line. Unfortunately jcommander does not make that possible. > `shiro_ini_path` is one example of an arg that would ideally print > differently here. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/config/CommandLine.java > 20858103315212d6ce6ccab8af62679e22991811 > > > Diff: https://reviews.apache.org/r/65234/diff/1/ > > > Testing > ------- > > Ran in vagrant. Here's an example output: > ```console > I0119 03:48:21.850 [main, CommandLine] > ----------------------------------------------------------------------- > I0119 03:48:21.854 [main, CommandLine] Parameters: > I0119 03:48:21.861 [main, CommandLine] -allow_container_volumes: true > I0119 03:48:21.861 [main, CommandLine] -allow_docker_parameters: false > I0119 03:48:21.861 [main, CommandLine] -allow_gpu_resource: true > I0119 03:48:21.861 [main, CommandLine] -allowed_container_types: [MESOS, > DOCKER] > I0119 03:48:21.861 [main, CommandLine] -allowed_job_environments: > ^(prod|devel|test|staging\d*)$ > I0119 03:48:21.861 [main, CommandLine] -async_slot_stat_update_interval: (1, > mins) > I0119 03:48:21.861 [main, CommandLine] -async_task_stat_update_interval: (1, > hrs) > I0119 03:48:21.862 [main, CommandLine] -async_worker_threads: 8 > I0119 03:48:21.862 [main, CommandLine] -backup_dir: /var/lib/aurora/backups > I0119 03:48:21.862 [main, CommandLine] -backup_interval: (1, hrs) > I0119 03:48:21.862 [main, CommandLine] -cluster_name: devcluster > I0119 03:48:21.862 [main, CommandLine] -cron_scheduler_num_threads: 10 > I0119 03:48:21.862 [main, CommandLine] -cron_scheduling_max_batch_size: 10 > I0119 03:48:21.862 [main, CommandLine] -cron_start_initial_backoff: (5, secs) > I0119 03:48:21.862 [main, CommandLine] -cron_start_max_backoff: (1, mins) > I0119 03:48:21.862 [main, CommandLine] -cron_timezone: GMT > I0119 03:48:21.862 [main, CommandLine] -custom_executor_config: null > I0119 03:48:21.862 [main, CommandLine] -default_docker_parameters: [] > I0119 03:48:21.862 [main, CommandLine] -dlog_max_entry_size: (512, KB) > I0119 03:48:21.862 [main, CommandLine] -dlog_snapshot_interval: (1, hrs) > I0119 03:48:21.862 [main, CommandLine] -enable_cors_for: null > I0119 03:48:21.862 [main, CommandLine] -enable_mesos_fetcher: false > I0119 03:48:21.862 [main, CommandLine] -enable_preemptor: true > I0119 03:48:21.862 [main, CommandLine] -enable_revocable_cpus: true > I0119 03:48:21.862 [main, CommandLine] -enable_revocable_ram: true > I0119 03:48:21.862 [main, CommandLine] -enable_update_affinity: false > I0119 03:48:21.863 [main, CommandLine] -executor_user: root > I0119 03:48:21.863 [main, CommandLine] -first_schedule_delay: (1, ms) > I0119 03:48:21.863 [main, CommandLine] -flapping_task_threshold: (5, mins) > I0119 03:48:21.863 [main, CommandLine] -framework_announce_principal: false > I0119 03:48:21.863 [main, CommandLine] -framework_authentication_file: null > I0119 03:48:21.863 [main, CommandLine] -framework_failover_timeout: (21, days) > I0119 03:48:21.863 [main, CommandLine] -framework_name: Aurora > I0119 03:48:21.863 [main, CommandLine] -global_container_mounts: > [Volume(containerPath:/home/vagrant/aurora/examples/vagrant/config, > hostPath:/home/vagrant/aurora/examples/vagrant/config, mode:RO), > Volume(containerPath:/home/vagrant/aurora/.auroraversion, > hostPath:/home/vagrant/aurora/.auroraversion, mode:RO)] > I0119 03:48:21.863 [main, CommandLine] -history_max_per_job_threshold: 100 > I0119 03:48:21.863 [main, CommandLine] -history_min_retention_threshold: (1, > hrs) > I0119 03:48:21.863 [main, CommandLine] -history_prune_threshold: (2, days) > I0119 03:48:21.863 [main, CommandLine] -hold_offers_forever: false > I0119 03:48:21.863 [main, CommandLine] -hostname: aurora.local > I0119 03:48:21.863 [main, CommandLine] -http_authentication_mechanism: BASIC > I0119 03:48:21.863 [main, CommandLine] -http_port: 8081 > I0119 03:48:21.863 [main, CommandLine] -initial_flapping_task_delay: (30, > secs) > I0119 03:48:21.863 [main, CommandLine] -initial_schedule_penalty: (1, secs) > I0119 03:48:21.863 [main, CommandLine] -initial_task_kill_retry_interval: > (15, secs) > I0119 03:48:21.863 [main, CommandLine] -ip: null > I0119 03:48:21.863 [main, CommandLine] -job_update_history_per_job_threshold: > 10 > I0119 03:48:21.863 [main, CommandLine] -job_update_history_pruning_interval: > (15, mins) > I0119 03:48:21.863 [main, CommandLine] -job_update_history_pruning_threshold: > (30, days) > I0119 03:48:21.863 [main, CommandLine] -kerberos_debug: false > I0119 03:48:21.863 [main, CommandLine] -kerberos_server_keytab: null > I0119 03:48:21.863 [main, CommandLine] -kerberos_server_principal: null > I0119 03:48:21.863 [main, CommandLine] -max_flapping_task_delay: (5, mins) > I0119 03:48:21.864 [main, CommandLine] -max_leading_duration: (1, days) > I0119 03:48:21.864 [main, CommandLine] -max_registration_delay: (1, mins) > I0119 03:48:21.864 [main, CommandLine] -max_reschedule_task_delay_on_startup: > (30, secs) > I0119 03:48:21.864 [main, CommandLine] -max_saved_backups: 48 > I0119 03:48:21.864 [main, CommandLine] -max_schedule_attempts_per_sec: 40.0 > I0119 03:48:21.864 [main, CommandLine] -max_schedule_penalty: (1, mins) > I0119 03:48:21.864 [main, CommandLine] -max_status_update_batch_size: 1000 > I0119 03:48:21.864 [main, CommandLine] -max_task_event_batch_size: 300 > I0119 03:48:21.864 [main, CommandLine] -max_tasks_per_job: 4000 > I0119 03:48:21.864 [main, CommandLine] -max_tasks_per_schedule_attempt: 5 > I0119 03:48:21.864 [main, CommandLine] -max_update_instance_failures: 20000 > I0119 03:48:21.865 [main, CommandLine] -mesos_driver: V1_DRIVER > I0119 03:48:21.865 [main, CommandLine] -mesos_master_address: > zk://localhost:2181/mesos > I0119 03:48:21.865 [main, CommandLine] -mesos_role: aurora-role > I0119 03:48:21.865 [main, CommandLine] -min_offer_hold_time: (5, mins) > I0119 03:48:21.865 [main, CommandLine] -native_log_election_retries: 20 > I0119 03:48:21.865 [main, CommandLine] -native_log_election_timeout: (15, > secs) > I0119 03:48:21.865 [main, CommandLine] -native_log_file_path: /var/db/aurora > I0119 03:48:21.865 [main, CommandLine] -native_log_quorum_size: 1 > I0119 03:48:21.865 [main, CommandLine] -native_log_read_timeout: (5, secs) > I0119 03:48:21.865 [main, CommandLine] -native_log_write_timeout: (3, secs) > I0119 03:48:21.865 [main, CommandLine] -native_log_zk_group_path: > /aurora/replicated-log > I0119 03:48:21.865 [main, CommandLine] -offer_filter_duration: (0, secs) > I0119 03:48:21.865 [main, CommandLine] -offer_hold_jitter_window: (1, mins) > I0119 03:48:21.865 [main, CommandLine] -offer_order: [RANDOM] > I0119 03:48:21.865 [main, CommandLine] -offer_order_modules: [class > org.apache.aurora.scheduler.offers.OfferManagerModule$OfferOrderModule] > I0119 03:48:21.865 [main, CommandLine] -offer_reservation_duration: (3, mins) > I0119 03:48:21.865 [main, CommandLine] -offer_selector_modules: [class > org.apache.aurora.scheduler.scheduling.FirstFitOfferSelectorModule] > I0119 03:48:21.865 [main, CommandLine] -offer_static_ban_cache_max_size: > 9223372036854775807 > I0119 03:48:21.865 [main, CommandLine] -partition_aware: true > I0119 03:48:21.865 [main, CommandLine] -populate_discovery_info: true > I0119 03:48:21.865 [main, CommandLine] -preemption_delay: (3, mins) > I0119 03:48:21.865 [main, CommandLine] > -preemption_reservation_max_batch_size: 5 > I0119 03:48:21.865 [main, CommandLine] -preemption_slot_finder_modules: > [class org.apache.aurora.scheduler.preemptor.PendingTaskProcessorModule, > class org.apache.aurora.scheduler.preemptor.PreemptionVictimFilterModule] > I0119 03:48:21.865 [main, CommandLine] -preemption_slot_hold_time: (5, mins) > I0119 03:48:21.865 [main, CommandLine] -preemption_slot_search_interval: (1, > mins) > I0119 03:48:21.865 [main, CommandLine] -receive_revocable_resources: true > I0119 03:48:21.865 [main, CommandLine] > -reconciliation_explicit_batch_interval: (5, secs) > I0119 03:48:21.865 [main, CommandLine] -reconciliation_explicit_batch_size: > 1000 > I0119 03:48:21.865 [main, CommandLine] -reconciliation_explicit_interval: > (60, mins) > I0119 03:48:21.866 [main, CommandLine] -reconciliation_implicit_interval: > (60, mins) > I0119 03:48:21.866 [main, CommandLine] -reconciliation_initial_delay: (1, > mins) > I0119 03:48:21.866 [main, CommandLine] -reconciliation_schedule_spread: (30, > mins) > I0119 03:48:21.866 [main, CommandLine] -require_docker_use_executor: true > I0119 03:48:21.866 [main, CommandLine] -scheduling_max_batch_size: 3 > I0119 03:48:21.866 [main, CommandLine] -serverset_endpoint_name: http > I0119 03:48:21.866 [main, CommandLine] -serverset_path: /aurora/scheduler > I0119 03:48:21.866 [main, CommandLine] -shiro_after_auth_filter: null > I0119 03:48:21.866 [main, CommandLine] -shiro_credentials_matcher: class > org.apache.shiro.authc.credential.SimpleCredentialsMatcher > I0119 03:48:21.866 [main, CommandLine] -shiro_ini_path: sections=users,roles > I0119 03:48:21.866 [main, CommandLine] -shiro_realm_modules: [class > org.apache.aurora.scheduler.http.api.security.IniShiroRealmModule] > I0119 03:48:21.866 [main, CommandLine] -sla_non_prod_metrics: [] > I0119 03:48:21.866 [main, CommandLine] -sla_prod_metrics: [JOB_UPTIMES, > PLATFORM_UPTIME, MEDIANS] > I0119 03:48:21.866 [main, CommandLine] -sla_stat_refresh_interval: (1, mins) > I0119 03:48:21.866 [main, CommandLine] -stat_retention_period: (1, hrs) > I0119 03:48:21.866 [main, CommandLine] -stat_sampling_interval: (1, secs) > I0119 03:48:21.866 [main, CommandLine] -task_assigner_modules: [class > org.apache.aurora.scheduler.scheduling.TaskAssignerImplModule] > I0119 03:48:21.866 [main, CommandLine] -thermos_executor_cpu: 0.25 > I0119 03:48:21.866 [main, CommandLine] -thermos_executor_flags: > --announcer-ensemble localhost:2181 --announcer-zookeeper-auth-config > /home/vagrant/aurora/examples/vagrant/config/announcer-auth.json > --mesos-containerizer-path=/usr/libexec/mesos/mesos-containerizer > I0119 03:48:21.866 [main, CommandLine] -thermos_executor_path: > /home/vagrant/aurora/dist/thermos_executor.pex > I0119 03:48:21.866 [main, CommandLine] -thermos_executor_ram: (128, MB) > I0119 03:48:21.866 [main, CommandLine] -thermos_executor_resources: [] > I0119 03:48:21.866 [main, CommandLine] -thermos_home_in_sandbox: false > I0119 03:48:21.866 [main, CommandLine] -thrift_method_interceptor_modules: [] > I0119 03:48:21.866 [main, CommandLine] -tier_config: > /home/vagrant/aurora/src/main/resources/org/apache/aurora/scheduler/tiers.json > I0119 03:48:21.866 [main, CommandLine] -transient_task_state_timeout: (5, > mins) > I0119 03:48:21.866 [main, CommandLine] -unavailability_threshold: (1, mins) > I0119 03:48:21.866 [main, CommandLine] > -update_affinity_reservation_hold_time: (3, mins) > I0119 03:48:21.866 [main, CommandLine] -viz_job_url_prefix: > I0119 03:48:21.867 [main, CommandLine] -webhook_config: null > I0119 03:48:21.867 [main, CommandLine] -zk_chroot_path: null > I0119 03:48:21.867 [main, CommandLine] -zk_connection_timeout: (10, secs) > I0119 03:48:21.867 [main, CommandLine] -zk_digest_credentials: null > I0119 03:48:21.867 [main, CommandLine] -zk_endpoints: [localhost:2181] > I0119 03:48:21.867 [main, CommandLine] -zk_in_proc: false > I0119 03:48:21.867 [main, CommandLine] -zk_session_timeout: (15, secs) > I0119 03:48:21.867 [main, CommandLine] > ----------------------------------------------------------------------- > ``` > > > Thanks, > > Bill Farner > >
