----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65281/#review196198 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java Lines 333 (patched) <https://reviews.apache.org/r/65281/#comment275747> We should only consider `UP` if the previous state is also `UP` for `PARTITIONED` state. For instance, `KILLING` -> `PARTITIONED` should we counted as `REMOVED`. - Santhosh Kumar Shanmugham On Jan. 24, 2018, 6:04 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65281/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 6:04 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Support PARTITIONED state in SLA calculations. Also added a test to protect > against this test failing in the future. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > 5d8d5bd8f705770979f284d26d2e932aabe707e5 > src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java > 2e719ac6b7aea86faa22deff2cc6b5f73135761c > > > Diff: https://reviews.apache.org/r/65281/diff/2/ > > > Testing > ------- > > ./gradlew test > > > Thanks, > > David McLaughlin > >
