----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65434/#review196561 -----------------------------------------------------------
src/main/python/apache/aurora/client/config.py Lines 47-49 (original), 49-50 (patched) <https://reviews.apache.org/r/65434/#comment276262> Note to reviewers: `config.raw().has_announce()` is already checked above so I could simplify the condition here. This is just a refactoring and independent of the behaviour change of this patch. - Stephan Erb On Jan. 31, 2018, 11:57 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65434/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 11:57 a.m.) > > > Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham. > > > Bugs: AURORA-1233 > https://issues.apache.org/jira/browse/AURORA-1233 > > > Repository: aurora > > > Description > ------- > > This eliminates false-positive warnings in the client: It used to complain > about unbound primary ports if those where bound via the portmap. > > > Diffs > ----- > > src/main/python/apache/aurora/client/config.py > adc8db0290d80a0ebfed983f6518d063f355d81f > src/test/python/apache/aurora/client/test_config.py > 3d5289adcb2d53506644604380797ff64227fecd > > > Diff: https://reviews.apache.org/r/65434/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Stephan Erb > >
