----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65649/#review197520 -----------------------------------------------------------
Ship it! Ship It! - Stephan Erb On Feb. 14, 2018, 6:05 a.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65649/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2018, 6:05 a.m.) > > > Review request for Aurora, Jordan Ly and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Adding support in the scheduler to receive a JSON request which defines a > UTF-8 charset in the Content-Type inside of the HTTP Request Headers. > > This fixes the current UI brakage as Thrift is incorrectly rejected by the > scheduler servlet as an unsupported media type. > > Adding a test to prevent regressions. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > 91ff8d32be1dacd35c7ba74b666479a61aede296 > src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java > 10da43bdc113791d0644dcc480476323f86cc66e > > > Diff: https://reviews.apache.org/r/65649/diff/1/ > > > Testing > ------- > > End to end testing > Loading up UI in different browsers in order to make sure thrift.js was not > cached. > vagrant destroy && vagrant up > > > Thanks, > > Renan DelValle > >
