----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65735/#review197935 -----------------------------------------------------------
Ship it! Master (e2ea191) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 21, 2018, 4:31 p.m., Franck Cuny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65735/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 4:31 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Summary: > Running `job status` on a job with GPUs fails, because the resource type is > not > know. The solution is to add the GPU type to the resources. > > Test Plan: > Ran the unit tests and built the client: > ``` > ./dist/aurora_internal.pex job status <job name> > INFO] Checking status of <job name> > Active tasks (1): > Task role: <role>, env: <env>, name: <name>, instance: 0, status: > RUNNING on <host> > CPU: 22.0 core(s), RAM: 131072 MB, Disk: 40960 MB, Port: http, GPU: 8 > GPU(s) > assigned ports: {u'http': 31891} > failure count: 0 (max 1) > events: > 2018-02-18 10:02:57 PENDING: None > 2018-02-18 10:02:57 ASSIGNED: None > 2018-02-18 10:02:58 STARTING: Initializing sandbox. > 2018-02-18 10:03:00 RUNNING: No health-check defined, task is > assumed healthy. > metadata: > (key: 'package', value: 'aaitken/twml_gpu version:7') > (key: 'package', value: 'aaitken/train_resnet version:212') > (key: 'package', value: 'aaitken/deps_pex version:62') > Inactive tasks (0): > ``` > > Differential Revision: https://phabricator.twitter.biz/D140046 > > > Diffs > ----- > > src/main/python/apache/aurora/config/resource.py > 85e1d002e295feb312ba5d6033295705e0c2d2af > src/test/python/apache/aurora/config/test_resources.py > f43bad725e397d04817ccbf1c76229d572185d99 > > > Diff: https://reviews.apache.org/r/65735/diff/4/ > > > Testing > ------- > > > Thanks, > > Franck Cuny > >
