----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65824/ -----------------------------------------------------------
Review request for Aurora, David McLaughlin, Renan DelValle, and Santhosh Kumar Shanmugham. Repository: aurora Description ------- I had to revert the previous fix due to a bug around `JobDataMap` and manipulating it outside of a Quartz execution. See https://reviews.apache.org/r/65810/ for context. I believe that we can mitigate this by creating an `AtomicBoolean` and manipulating that within the `batchWorker` execution as opposed to directly changing the `JobDataMap`. This mirrors the previous behavior of `killFollowups` but while keeping the state within a given job context. Diffs ----- src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 3604dd4c84043def3fe098ca0f87bf8bab99b3db src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 5083fcd407a069617634b82db1ad799b5d4d4551 Diff: https://reviews.apache.org/r/65824/diff/1/ Testing ------- `./gradlew test` Manually verified bug in previous patch no longer occurs. Verified the bug the previous patch was fixing no longer occurs as well. Will deploy to a test cluster. Question for reviewers: Is it worthwhile to add end-to-end tests for scheduling crons and ensuring KILL_EXISTING works? The reason I am hesitant is that the coverage of this feature seem comprehensive enough but the bug that slipped through the previous patch was due to a subtle interaction with the Quartz scheduler which we mock in unit tests. Thanks, Jordan Ly
