-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66136/#review199438
-----------------------------------------------------------
Master (aaadad7) is red with this patch.
./build-support/jenkins/build.sh
Pass 2: Analyzing classes (319 / 332) - 96% complete
Pass 2: Analyzing classes (320 / 332) - 96% complete
Pass 2: Analyzing classes (321 / 332) - 96% complete
Pass 2: Analyzing classes (322 / 332) - 96% complete
Pass 2: Analyzing classes (323 / 332) - 97% complete
Pass 2: Analyzing classes (324 / 332) - 97% complete
Pass 2: Analyzing classes (325 / 332) - 97% complete
Pass 2: Analyzing classes (326 / 332) - 98% complete
Pass 2: Analyzing classes (327 / 332) - 98% complete
Pass 2: Analyzing classes (328 / 332) - 98% complete
Pass 2: Analyzing classes (329 / 332) - 99% complete
Pass 2: Analyzing classes (330 / 332) - 99% complete
Pass 2: Analyzing classes (331 / 332) - 99% complete
Pass 2: Analyzing classes (332 / 332) - 100% complete
Done with analysis
:test
org.apache.aurora.scheduler.events.WebhookTest >
testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:251
I0319 17:20:50.604 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1081 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated:
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 6m 56s
45 actionable tasks: 36 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 19, 2018, 2:55 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66136/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 2:55 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Renan DelValle.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is the first part of a small series of Thermos observer performance
> improvements.
>
> As a first iteration, this switches all logging to use the logger-embedded
> formatting
> rather than doing it eager up front. This has the advantage that we produce
> less garbage
> if debug logging is disabled.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/common/ckpt.py
> e79ec6ac42483bfab4ccd94390d0f2af95903a95
> src/main/python/apache/thermos/core/helper.py
> 0811e846ce8e39a22d55732604876c37d2caa239
> src/main/python/apache/thermos/core/muxer.py
> 47e77f7685891545b2526e71e016ffcd454f938c
> src/main/python/apache/thermos/core/process.py
> 4a4678ff39c84cb87836aca19365c5b2aabc4fa4
> src/main/python/apache/thermos/core/runner.py
> 1b63c083246f8ec1a43cb1686968c2b1bb4a14b5
> src/main/python/apache/thermos/monitoring/disk.py
> 52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21
> src/main/python/apache/thermos/monitoring/monitor.py
> d77703e9027e6c23ffb67d936cf8beef0384b4a6
> src/main/python/apache/thermos/monitoring/process_collector_psutil.py
> 3000e95e2930a01f57ac855960b5db7aabbfc0ca
> src/main/python/apache/thermos/monitoring/resource.py
> f5e3849ca6682c6d4720698be869ca6b9f703b94
> src/main/python/apache/thermos/observer/http/file_browser.py
> d0996651312a763ed68a68ae358524cfb4a94d29
> src/main/python/apache/thermos/observer/http/http_observer.py
> 5bfc4f28bfbbcb654a059a3579844f5dbe082a9b
> src/main/python/apache/thermos/observer/http/static_assets.py
> 83adeb3e699274483cb72910b0d25f7b30098f24
> src/main/python/apache/thermos/observer/observed_task.py
> 08540e11523b0db990de57fe1ce7517047e2632b
> src/main/python/apache/thermos/observer/task_observer.py
> 4bb5d239e81fe4659397f899760c0e8853e93786
> src/main/python/apache/thermos/runner/thermos_runner.py
> fa4f0fb7452bf8b85f9f3fa27283f54d7c0fe4f2
>
>
> Diff: https://reviews.apache.org/r/66136/diff/1/
>
>
> Testing
> -------
>
> Manually verified that the observer debug logs still contain useful output.
>
>
> Thanks,
>
> Stephan Erb
>
>