> On March 19, 2018, 5:41 p.m., David McLaughlin wrote: > > Not sure how possible it is given the requirement for a completely custom > > executor, but e2e coverage would be great.
Definitely possible, it's the end goal of going through my Aurora DSL backlog. I will most likely have to use DCE-GO (https://github.com/paypal/dce-go) in an e2e test after adding support to the DSL for the Mesos fetcher (https://issues.apache.org/jira/browse/AURORA-1982). - Renan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199504 ----------------------------------------------------------- On March 19, 2018, 4:33 p.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66154/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 4:33 p.m.) > > > Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan > Erb. > > > Bugs: AURORA-1981 > https://issues.apache.org/jira/browse/AURORA-1981 > > > Repository: aurora > > > Description > ------- > > Adding executor_config as a field to MesosJob in order to allow the use of > custom executors through the DSL. > > First patch in a series to catch up on some work I have backlogged regarding > custom executors. > > > Diffs > ----- > > RELEASE-NOTES.md b5d06c42badd3b623ad365a5d34a7162e8c782f2 > docs/features/custom-executors.md 1357c1ed334dbd90ac9937c557766ce31686c293 > docs/reference/configuration.md 725e073e8057f0e5e17f50285d86c89638c96d16 > src/main/python/apache/aurora/config/schema/base.py > 3d57d6a68b9553938c8ef8a15e6ac88d466f7c3c > src/main/python/apache/aurora/config/thrift.py > dcabb03500c8e60d5585f0e65c74e163bd93e43a > src/test/python/apache/aurora/client/cli/test_inspect.py > 8c624800eed383383dfb07c10aae103c54875728 > src/test/python/apache/aurora/config/test_thrift.py > 7bf050836633780401c5d8a371e006bde025c420 > > > Diff: https://reviews.apache.org/r/66154/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Renan DelValle > >
