----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66186/#review199603 -----------------------------------------------------------
src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py Line 22 (original), 22 (patched) <https://reviews.apache.org/r/66186/#comment279928> `process_iter` used to be an implementation detail of `Process.children()` but got removed in https://github.com/giampaolo/psutil/pull/1185/files - Stephan Erb On March 21, 2018, 12:15 a.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66186/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 12:15 a.m.) > > > Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x > faster on Linux.` > > This is needed for all stats retrieved via `ProcessTreeCollector`. An update > therefore > seems worthwhile. > > https://github.com/giampaolo/psutil/blob/master/HISTORY.rst > > > Diffs > ----- > > 3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 > src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py > 93ff878be578fa7a63d25b65e7d915790dc9ccc6 > > > Diff: https://reviews.apache.org/r/66186/diff/1/ > > > Testing > ------- > > TODO: I still want to double check this on a real running observer > > > Thanks, > > Stephan Erb > >
