-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66192/#review199632
-----------------------------------------------------------
Master (f32086d) is red with this patch.
./build-support/jenkins/build.sh
found: IJobUpdateInstructions,boolean
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java:78:
error: method newUpdate in interface UpdateFactory cannot be applied to given
types;
Update update = factory.newUpdate(IJobUpdateInstructions.build(config),
true);
^
required: IJobUpdate,boolean,Storage
found: IJobUpdateInstructions,boolean
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java:89:
error: method newUpdate in interface UpdateFactory cannot be applied to given
types;
Update update = factory.newUpdate(IJobUpdateInstructions.build(config),
false);
^
required: IJobUpdate,boolean,Storage
found: IJobUpdateInstructions,boolean
reason: actual and formal argument lists differ in length
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java:98:
error: method newUpdate in interface UpdateFactory cannot be applied to given
types;
Update update = factory.newUpdate(IJobUpdateInstructions.build(config),
true);
^
required: IJobUpdate,boolean,Storage
found: IJobUpdateInstructions,boolean
reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
5 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 48s
28 actionable tasks: 22 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On March 21, 2018, 2:10 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66192/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 2:10 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and
> Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support for variable group sizes when executing an update.
>
> Design doc for this change is here:
> https://docs.google.com/document/d/1xGk4ueH8YlmJCk6hQJh85u4to4M1VQD0l630IOchvgY/edit#heading=h.lg3hty82f5cz
>
> I opted for the path of least resistance with regards to the Thrift changes
> as I didn't see any benefit in making the larger changes required to make the
> interfaces a bit more flexible.
>
> Requesting feedback on these changes and the approach from the community
> before I proceed.
>
> Tests will be added after the community approves of the direciton and
> approach.
>
> Note to reviewers: Changes made in ActiveLimitedStrategy.java were made to
> move towards getting rid of FluentIterable. I figured since I was touching
> that code, it wouldn't hurt to test the Java 8 equivalent of it. I can get
> rid of the change here and make it in a separate patch if desired.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift
> ef754e32172e7490a47a13e7b526f243ffa3efeb
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift
> b79e2045ccda05d5058565f81988dfe33feea8f1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java
> b25f3831cecc58c90375c90b16142421f8f09e38
> src/main/java/org/apache/aurora/scheduler/storage/durability/Loader.java
> 10864f122eff5027c88d835baae6de483d960218
>
> src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java
> 8d70cae35289a9e36142bab288cf0c9398ebd2d4
>
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java
> 9e86b9e276ea90a249284a824705b5bbf19dcbce
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
> 9fc0416086dd3eb2e2f4e8f659da59fcdea2b22b
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
> f8be8058f3a80a18b999d2666e2adb33e1e55fef
> src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
> 3992aa77fc305adc390a4aaeb1d3939d6241ddbd
>
> src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java
> 855ea9c20788b51695b7eff5ac0970f0d52a9546
>
> src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66192/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Renan DelValle
>
>
