> On March 21, 2018, 10:47 a.m., Santhosh Kumar Shanmugham wrote: > > Ship It!
I am a little confused about the performance testing results that are posted here, since the pervious results indicated gains from 2secs to 0.2secs, while the current one is much lesser. Can you add a little bit of context regarding the results? Thanks. - Santhosh Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199681 ----------------------------------------------------------- On March 20, 2018, 3:41 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66139/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 3:41 p.m.) > > > Review request for Aurora, Jordan Ly, Renan DelValle, and Reza Motamedi. > > > Repository: aurora > > > Description > ------- > > Profiling indicates that a significant part of the refresh time os spend in > `os.path.realpath`. > This was introduced in https://reviews.apache.org/r/35580/ to properly handle > the `latest` > symlink in the Mesos folder layout. > > This patch takes a slightly different approach to solve this problem based on > `os.path.islink`. > The latter is faster as it just needs to look at a single folder rather than > an entire path. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/path_detector.py > ed264d74ef5a5a7aa681a56b340f9b16504a88ad > src/test/python/apache/aurora/executor/common/test_path_detector.py > 7b5ef0cf552d22d4cfbf3357071de036551026dc > > > Diff: https://reviews.apache.org/r/66139/diff/2/ > > > Testing > ------- > > I have tested this build on a node with 55 running tasks and 2004 finished > ones. > > Before this patch: > > D0320 22:20:44.887248 25771 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.92s > D0320 22:20:50.746316 25771 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.93s > D0320 22:20:56.590157 25771 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.89s > > With this patch: > > D0320 22:18:53.545236 16250 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.48s > D0320 22:18:59.031919 16250 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.49s > D0320 22:19:04.512358 16250 task_observer.py:142] TaskObserver: finished > checkpoint refresh in 0.48s > > > Thanks, > > Stephan Erb > >
