----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66537/ -----------------------------------------------------------
(Updated April 11, 2018, 1:45 a.m.) Review request for Aurora, Renan DelValle and Stephan Erb. Changes ------- Corrects ReviewBot's Python checkstyle issues @ReviewBot retry Repository: aurora Description ------- Hey there! Over here at Spine we've added a few enhancements to Aurora's Docker functionality to support several of our use cases. We'd like to submit these back up to the upstream to support the great work y'all are doing in this space. Here's what's included in this RB: * Support for the force_pull flag to help ensure container freshness * Overrides for a Docker --entrypoint which can be specified on the job * Support for alternative Docker networks (defaults to HOST) * Support for user Docker networks We currently use Aurora to schedule Docker containers without the use of Thermos, so we've added support for server-side templating of common Thermos variables into Docker executor's parameters for this purpose. This change modifies Aurora's api.thrift with several new optional fields, and all added code handles their absence gracefully, so no backfills have been added. We've threaded these schema changes through to the Python Aurora client alongside support for the Mesos Fetcher URIs already supported server-side. Let me know what you think and thanks! Diffs (updated) ----- .gitignore 9ce74ebbbc57b77d912eaa573a8fb18ed4aa3c15 api/src/main/thrift/org/apache/aurora/gen/api.thrift ef754e32172e7490a47a13e7b526f243ffa3efeb src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java bcb2bbf882f43d813dd26c746d806e78bae6bcf3 src/main/python/apache/aurora/config/schema/base.py a629bcd1261e5959da0a8458a55545d4e2c2a7a5 src/main/python/apache/aurora/config/thrift.py 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 778148a7c033cba9004954cabc33a2b1d003dccf src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 686087ef858b8a5a8e956d82a7bd692f7be28b12 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40851c419e4d62e6545959eebc0ce144fdecc697 src/test/python/apache/aurora/config/test_thrift.py 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob 88e1c36a1aa2d192b95963f7aa36e243a447e4af src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks 4323031ec6bd128576c2a43ebc11f04a9f046e2f Diff: https://reviews.apache.org/r/66537/diff/2/ Changes: https://reviews.apache.org/r/66537/diff/1-2/ Testing ------- Unit tests for all new functionality have been added and run cleanly alongside checkstyle/static analysis tooling. Operational/functional testing completed within Spine infrastructure. Thanks, Steve Salevan
