----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200954 -----------------------------------------------------------
Ship it! Ship It! - David McLaughlin On April 12, 2018, 1:05 a.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66573/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 1:05 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and > Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Between failovers, tasks that normally would not require preemption could be > in a PENDING state for an extended period of time and become eligible for > preemption. Thus, when the scheduler starts, offers could not have been > processed yet and the tasks can preempt other tasks needlessly. > > Added an initial delay to preemption slot searching on scheduler startup so > PENDING tasks have a chance to be scheduled before preempting. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 7618efc2c0cb46e96119accd2c7962ea8ee7a05e > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java > 0a16d3c95d3f262686936330ac7d7dc332d759d5 > > > Diff: https://reviews.apache.org/r/66573/diff/1/ > > > Testing > ------- > > `./gradlew test` > > Will deploy on a cluster to ensure preemption does not start for the initial > interval. > > > Thanks, > > Jordan Ly > >
