----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67657/#review205038 -----------------------------------------------------------
Ship it! Master (3140448) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 19, 2018, 10:30 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67657/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 10:30 p.m.) > > > Review request for Aurora, David McLaughlin, Franck Cuny, and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > With the introduction of `timeoutSecs` for HostMaintenanceRequest > and the `CoordinatorSlaPolicy`, it will be beneficial to expose the > time remaining until forced maintenance to the Coordinator. Send > the time remaining until force task maintenance as an extra query > param to the Coordinator. > > > Diffs > ----- > > docs/features/sla-requirements.md 555b174d2324b0b1b596a3da72b0a5a67fcca153 > > src/main/java/org/apache/aurora/scheduler/maintenance/MaintenanceController.java > 626a68263d6118f138cd6012fd49e033b09b75f0 > src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java > 9c5caf4af8e8c8bad408100af2bc4fe045603340 > > src/test/java/org/apache/aurora/scheduler/maintenance/MaintenanceControllerImplTest.java > c9390df25f7eacbab14a508b1926a05aac8112d6 > src/test/java/org/apache/aurora/scheduler/sla/SlaManagerTest.java > 759a1bca4814b2cf70a20eac26aaabfcef682332 > > > Diff: https://reviews.apache.org/r/67657/diff/1/ > > > Testing > ------- > > ./gradlew test > > **Tested on Vagrant** > > ***Logs from Coordinator*** > Request received for {'countdown-ms': ['94784'], 'task': > ['devcluster/vagrant/test/coordinator/1']} > Responded: False > Request received for {'countdown-ms': ['34777'], 'task': > ['devcluster/vagrant/test/coordinator/1']} > Responded: False > > > Thanks, > > Santhosh Kumar Shanmugham > >
