-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68047/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar 
Shanmugham, and Stephan Erb.


Repository: aurora


Description
-------

Currently, we only track the size metrics for:
- # of tasks via `task_store_index_(host|job)`
- # of crons via `mem_storage_cron_size`

I am hoping to add:
- # of attributes via `mem_storage_attributes_size`
- # of maintenance requests via `mem_storage_maintenance_size`
- # of job updates via `mem_storage_update_size`
- # of quotas via `mem_storage_quota_size`

This will help us track the growth of stores over time. Additionally, I added a 
`MemSchedulerStoreTest` since one did not exist previously and nothing was 
extending the abtract version of the test.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java 
67684cfd9c17c6a86999a66dbd4dd9c2ef9a9938 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 
a1e1f1ef7ab3bc1b0082c31c860f144f95e78fae 
  
src/main/java/org/apache/aurora/scheduler/storage/mem/MemHostMaintenanceStore.java
 c8d96f2cfd2fdcf8d80fd089b032dbd14a1e72b9 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java 
9e86b9e276ea90a249284a824705b5bbf19dcbce 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java 
afb29fce68c432a2155d3e503d35e10c58b262be 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractAttributeStoreTest.java
 687fd963a5e782c7892b2cbbbcaf283653aed30f 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 
889cb01a0f1845ebddc44d6d737228f32665a628 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractHostMaintenanceStoreTest.java
 e95955c29c28d2c4474debcde2ad3fa2a9047578 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java
 6af66aa79788c07b006f163b4546c25b8ff36012 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractQuotaStoreTest.java 
e1d7da51503a1ea1c1748e14e439b81109b45047 
  
src/test/java/org/apache/aurora/scheduler/storage/AbstractSchedulerStoreTest.java
 cb8051927b66676a1e7afbbd9e1a3d10a037f429 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
c53e5847a673e398413b80fbd1a9bde9c3774cab 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStoreTest.java
 64b19a9f2ca7c60c983b4dac1704c3056513fc2b 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java 
15e0e309f6b92ffb8b268b5e0e94e81054ee7a2c 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemHostMaintenanceStoreTest.java
 ce1a9d6a0749df465129fc8fc22b9483551ca02a 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStoreTest.java
 cbf1bc4fe4a9ca814cd948cc99b9107c0be59615 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStoreTest.java 
e8324eecafd91789b6ddee24300e59399641a05e 
  
src/test/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStoreTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/68047/diff/1/


Testing
-------

`./gradlew test`

I will deploy to vagrant and ensure the new metrics are being recorded.


Thanks,

Jordan Ly

Reply via email to