----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66192/#review207930 -----------------------------------------------------------
Ship it! Master (29eae2c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 24, 2018, 11:43 p.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66192/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2018, 11:43 p.m.) > > > Review request for Aurora, David McLaughlin, Jordan Ly, Santhosh Kumar > Shanmugham, and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Adding support for variable group sizes when executing an update. > > Design doc for this change is here: > https://docs.google.com/document/d/1xGk4ueH8YlmJCk6hQJh85u4to4M1VQD0l630IOchvgY/edit#heading=h.lg3hty82f5cz > > I opted for the path of least resistance with regards to the Thrift changes > as I didn't see any benefit in making the larger changes required to make the > interfaces a bit more flexible. > > Requesting feedback on these changes and the approach from the community > before I proceed. > > Tests will be added after the community approves of the direciton and > approach. > > Note to reviewers: Changes made in ActiveLimitedStrategy.java were made to > move towards getting rid of FluentIterable. I figured since I was touching > that code, it wouldn't hurt to test the Java 8 equivalent of it. I can get > rid of the change here and make it in a separate patch if desired. > > > Diffs > ----- > > RELEASE-NOTES.md e6edbdeb577450f1119183a247e54a00e8a964d1 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > dac2267dfe7e2e7563568adf8f04f6e9edc598d4 > docs/reference/configuration.md 0632559e83ab1b547541c4087ae503318d2590d5 > examples/jobs/hello_world_variable_update.aurora PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java > 41a2f0b5b897c4fc3437cc8fd052478a4de8a426 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 74820c99ef769083a247608691dd7dea117a673a > src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java > bc8008ec5dcba98923703d0d35881f3fea7c5b2d > > src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java > 855ea9c20788b51695b7eff5ac0970f0d52a9546 > > src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java > PRE-CREATION > src/main/python/apache/aurora/client/api/__init__.py > 34822bcbacbba7ca6c3cd6ebf7f63a5f9d1c820f > src/main/python/apache/aurora/client/api/updater_util.py > 5c2d95384a639a08cb0f2dece83c671de7e54764 > src/main/python/apache/aurora/config/schema/base.py > bf75660f44240ec78f27f8fc76418968bd0e2fc7 > src/main/python/apache/aurora/config/thrift.py > 2ffa5b6905ecfbd1835df60cfe861a13f08a6492 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java > 3a93650635fb92fea306498cb86e35a0e25cf847 > > src/test/java/org/apache/aurora/scheduler/storage/durability/DataCompatibilityTest.java > 3372ceccbd91629d5fc3f45ac1ebdebc19326b32 > > src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java > ddb9d06928de8ba73b6592b79cc741e5e97f0ff0 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotterImplIT.java > 4c1918fc33b5123dc522c49739dcf5690bdec3b0 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 334fd5d321d202cd9dfc10941c43fd07e0296aeb > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > c96def1a51d354d0a55cbb6f574306ef2b5237c2 > > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > 01bdcf1f0613b9c0297321762e0d2b032dd4841c > > src/test/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategyTest.java > PRE-CREATION > src/test/python/apache/aurora/client/api/test_api.py > 9d6d9de903bf0cb9ac2b6415e76f8fb70e051514 > src/test/python/apache/aurora/client/api/test_updater_util.py > 48926c3695dbcf38abd33b2d58a64d8e1ea1cdd3 > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate > 3876767610f1d535d95b7dbe5d27dd8188b42f05 > > > Diff: https://reviews.apache.org/r/66192/diff/4/ > > > Testing > ------- > > Jenkins integration test. > > Watiing on end to end tests as they might be currently broken. > > > Thanks, > > Renan DelValle > >
