StephanErb commented on a change in pull request #37: Staggered (Variable batch) Updates URL: https://github.com/apache/aurora/pull/37#discussion_r217483009
########## File path: docs/reference/configuration.md ########## @@ -376,8 +376,34 @@ Parameters for controlling the rate and policy of rolling updates. | ```rollback_on_failure``` | boolean | When False, prevents auto rollback of a failed update (Default: True) | ```wait_for_batch_completion```| boolean | When True, all threads from a given batch will be blocked from picking up new instances until the entire batch is updated. This essentially simulates the legacy sequential updater algorithm. (Default: False) | ```pulse_interval_secs``` | Integer | Indicates a [coordinated update](../features/job-updates.md#coordinated-job-updates). If no pulses are received within the provided interval the update will be blocked. Beta-updater only. Will fail on submission when used with client updater. (Default: None) +| ```update_strategy``` | Choice of ```QueueUpdateStrategy```, ```BatchUpdateStrategy```, or ```VariableBatchUpdateStrategy``` object | Indicate which update strategy to use for this update. | ```sla_aware``` | boolean | When True, updates will only update an instance if it does not break the task's specified [SLA Requirements](../features/sla-requirements.md). (Default: None) +### QueueUpdateStrategy Objects + +Update strategy which will keep the active updating instances at size ```batch_size``` throughout the update until there are no more instances left to update. + +| object | type | description +| ---------------------------- | :------: | ------------ +| ```batch_size``` | Integer | Maximum number of shards to be updated in one iteration (Default: 1) + +### BatchUpdateStrategy Objects + +Update strategy which will wait until a maximum of ``batch_size`` number of instances are updated before continuing on to the next group until all instances are updated. + +| object | type | description +| ---------------------------- | :------: | ------------ +| ```batch_size``` | Integer | Maximum number of shards to be updated in one iteration (Default: 1) + +### VariableBatchUpdateStrategy Objects + +Similar to Batch Update strategy, this strategy will wait until all instances in a current group are updated before updating more instances. +However, with this strategy the size of each group may change as the update progresses. Review comment: This sentence seems to contradict `"Each batch behaves in the same way as the static batch update strategy where the group size remains constant throughout the update."` from the RELEASE-NOTES. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
