rdelval commented on a change in pull request #37: Staggered (Variable batch)
Updates
URL: https://github.com/apache/aurora/pull/37#discussion_r221020632
##########
File path: src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java
##########
@@ -76,12 +77,10 @@ Update newUpdate(
public Update newUpdate(IJobUpdateInstructions instructions, boolean
rollingForward) {
requireNonNull(instructions);
IJobUpdateSettings settings = instructions.getSettings();
+
checkArgument(
settings.getMinWaitInInstanceRunningMs() >= 0,
"Min wait in running must be non-negative.");
- checkArgument(
Review comment:
I agree it's a bit disjoint. The validation for group sizes is being done
[here](https://github.com/apache/aurora/pull/37/files/49646d0097546cc070fb0a4b3555cca482dceb28#diff-2b88151c5903ffbb593ec7812574f9c4R812)
and I couldn't come up with a scenario where this wouldn't protect us from a
bad update config.
Do you think I should abstract that code to a function and call it here as
well?
I thought it was
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
