dknig1b commented on a change in pull request #41: Memoize loader.load and loader.load_json URL: https://github.com/apache/aurora/pull/41#discussion_r221681127
########## File path: src/test/python/apache/aurora/config/test_loader.py ########## @@ -93,6 +101,27 @@ def test_load_json_single(): assert new_job == job +def test_load_json_memoized(): Review comment: 1) write the json with job[0] and read it with memoizing and assert that I have job[0] 2) overwrite the config with write the json for job[1] and read with memozation and assert I still have job[0] (cached content) 3) read without memoization and assert I have job[1] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
