DavidMcLaughlin commented on a change in pull request #41: Memoize loader.load and loader.load_json URL: https://github.com/apache/aurora/pull/41#discussion_r221762084
########## File path: src/test/python/apache/aurora/config/test_loader.py ########## @@ -93,6 +101,27 @@ def test_load_json_single(): assert new_job == job +def test_load_json_memoized(): Review comment: I see. I don't think that's really intuitive. Can you at least add a comment explaining that it's testing memoization by proxy? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
