mauri commented on a change in pull request #54: Auto Pause for Batch based update strategies URL: https://github.com/apache/aurora/pull/54#discussion_r317343268
########## File path: docs/reference/configuration.md ########## @@ -394,6 +394,7 @@ Update strategy which will wait until a maximum of ``batch_size`` number of inst | object | type | description | ---------------------------- | :------: | ------------ | ```batch_size``` | Integer | Maximum number of shards to be updated in one iteration (Default: 1) +| ```autopause_after_batch``` | Boolean | Automatically pauses update before starting a new batch. (Default: False) Review comment: Given the flag name refers to what to do "after batch", the update pauses after the last batch, but not before the first one; I think it would be more clear to rephrase the description to something along "pauses the update after completing a batch" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
