-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31414
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59883>

    from apache



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59886>

    revert?



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59887>

    revert?



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59885>

    revert?



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16423/#comment59884>

    revert?



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59888>

    join() accepts a generator so [] can be removed.  nbd.



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59889>

    i think AuroraJobKeys have an __iter__ method so you can unwrap this if you 
want:
    
    cluster, role, env, name = context.options.rename_from
    



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59890>

    if result not in (0, 1):



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16423/#comment59891>

    ultra-minor nit -- if we ever add more constraints other than order= to 
Constraint, this could break, so you _may_ want to say 'constant.order() or []'



src/test/python/twitter/aurora/client/cli/BUILD
<https://reviews.apache.org/r/16423/#comment59892>

    missed merge


- Brian Wickman


On Jan. 9, 2014, 12:12 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 12:12 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/apache/aurora/client/options.py 
> af56351eed21805f09bfe50cb91745d58b665627 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
> already tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to