> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 206
> > <https://reviews.apache.org/r/16528/diff/3/?file=417935#file417935line206>
> >
> >     Feel free to omit this comment.  I find the behavior pretty obvious 
> > from the args.

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 214
> > <https://reviews.apache.org/r/16528/diff/3/?file=417935#file417935line214>
> >
> >     revert

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 198
> > <https://reviews.apache.org/r/16528/diff/3/?file=417938#file417938line198>
> >
> >     I'm usually a fan of inlining functions where the body is one line and 
> > there's a single caller — less code overall.
> >     
> >     Ditto below.

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 26
> > <https://reviews.apache.org/r/16528/diff/3/?file=417945#file417945line26>
> >
> >     Looks like leftover testing code.  Please remove.

I left the mocks intentionally so I can use it in the stand alone UI. Removed 
it now.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31390
-----------------------------------------------------------


On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 8:10 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented new Scheduler home page using AngularJS. The UI queries the 
> backend using the thrift end point. This diff sets the basic foundation for 
> the page. Sending this out to get some early feedback and to keep the future 
> diffs small.
> 
> The URLs in the new UI will redirect to the scheduler role pages. 
> 
> Dropped the option to select number of results to be shown to simplify the 
> interface. Now defaulting to 25 results per page.
> 
> Cleaned up the UI to make it more light weight.
> 
> Added a mock service to render dummy data on the page. Currently, this mock 
> service is manually wired during testing. Will created an isolated scheduler 
> page once we have a single page app.
> 
> Updated build.gradle to generate thrift JS client. 
> 
> Installed Angular and smart-table from bower. Added thrift.js file to make 
> the calls to the backend. Will migrate to angular-thrift for more robust 
> implementation in coming diffs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.map 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION 
>   3rdparty/javascript/thrift.js PRE-CREATION 
>   build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
> d775edeae93d61850a8619a6675699560e941277 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 
> 263591a1a387731be11936a7ad244cdc81b40a10 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> a3faf6be3635ec4f985867dd4598ad434a985fb7 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 
> 5e540f303ffa3d057dea564b394a29508b03c03c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16528/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> 
> Tested the UI using the isolated scheduler. 
> 
> 
> File Attachments
> ----------------
> 
> Home page
>   
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to