> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.
> 
> Tobias Weingartner wrote:
>     I'm ok with that.
> 
> Tom Galloway wrote:
>     Yeah, I'm sorry about that. I actually did submit all the docs 
> separately, and for some reason git/apache combined it into one massive lump.
> 
> Bill Farner wrote:
>     I'll be okay without 100% consensus, but i would like to clean up some of 
> the formatting issues to avoid proliferation of those.  Specifically, the 
> trailing newlines and trailing whitespace.
> 
> Tom Galloway wrote:
>     Bill, I think I fixed those, except where, as replied to your review, 
> it's a Markdown thing (specifically, two spaces at the end of a line is a 
> specific Markdown format thing).

Thanks for setting me straight on that.  Given that we've already crossed the 
threshold of not being HTML-free, i'd prefer <br> over trailing whitespace.  
Regarding your fixes, can you please send the updated diff so we can see the 
changes?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
-----------------------------------------------------------


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -----
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Reply via email to