----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16629/ -----------------------------------------------------------
(Updated Jan. 15, 2014, 8:56 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes ------- CR comments addressed. Repository: aurora Description ------- Part 2: Server side changes for the client quota check. Refactored quota manager: - Merged QuotaFilter with QuotaManager and dropped JobFilter implementation; - Simplified quota manager logic by splitting data retrieval and quota checking steps; - Moved quota checks into write transaction to ensure consistency. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 785efd09a65568b174b35376c550ba5290e5915a src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java 99d2e4c72621708c971d25ad4e6722e0870093af src/main/java/org/apache/aurora/scheduler/quota/QuotaFilter.java 6ab79820a0634478c0525d7fdd5a4d002ef8ea08 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 6b0645ba93e50b576f7e572d8dc06231636fade2 src/main/java/org/apache/aurora/scheduler/quota/QuotaModule.java 4a619492f6e9eb41e693353187fc3b1781bffc1f src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 24f209339f3a6f4659693986e220187bd34d2fb5 src/main/java/org/apache/aurora/scheduler/state/JobFilter.java 0d84c1e2eff781e7d0250967ae6b9f9473fde3dc src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 8dec2831444a21125d250d98132aae1009b0e306 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 8fb51d69be6d370f9f010c797b2c1205b38a04f5 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 76caa6214dc53c79222bc4a1b9e5066b61839ec6 src/test/java/org/apache/aurora/scheduler/quota/QuotaComparisonResultTest.java 23069b8d191f1675636bceb8c297ebcc0d88d8dc src/test/java/org/apache/aurora/scheduler/quota/QuotaFilterTest.java b1d878ea91c02ba87059b05877208b702d3fbcae src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f971aa1882e5e9f4208d177566779f5dd12d70ce src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 4eeed38244904b64352ecc6c31111b66b2d0ced9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b46f29ad6cd1dd69fe31e73f2b8000dbf88508ea src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing ------- gradle build Thanks, Maxim Khutornenko
