> On Dec. 13, 2013, 4:15 p.m., Bill Farner wrote: > > build-support/tag-release, line 1 > > <https://reviews.apache.org/r/16265/diff/1/?file=397875#file397875line1> > > > > High-level comment would be really nice. I stopped short on the review > > because i'm not entirely clear on the workflow being targeted.
Done. > On Dec. 13, 2013, 4:15 p.m., Bill Farner wrote: > > build-support/tag-release, line 11 > > <https://reviews.apache.org/r/16265/diff/1/?file=397875#file397875line11> > > > > ensuring pwd == `git rev-parse --show-toplevel` would be more direct, > > and less brittle in the unlikely event we rename 'pants'. Done. > On Dec. 13, 2013, 4:15 p.m., Bill Farner wrote: > > build-support/tag-release, line 29 > > <https://reviews.apache.org/r/16265/diff/1/?file=397875#file397875line29> > > > > Shouldn't this part be done before parsing the version? Done. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review30382 ----------------------------------------------------------- On Jan. 15, 2014, 2:57 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16265/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 2:57 p.m.) > > > Review request for Aurora, Maxim Khutornenko, Bill Farner, and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Script for creating tags. The workflow is as follows: > > Example for tagging 0.2.0-SNAPSHOT > 0. Sanity checks. > 1. Create a release-0.2.x branch off master. > 2. Create a single commit on that branch moving .auroraversion from > 0.2.0-SNAPSHOT to 0.2.0. > 3. Create a tag 0.2.0 for that commit. > 4. Create a commit on master moving .auroraversion from 0.2.0-SNAPSHOT to > 0.3.0-SNAPSHOT. > 5. More sanity checks, then everything can be pushed, downstream artifacts > can be built/published. > > > Diffs > ----- > > build-support/tag-release PRE-CREATION > > Diff: https://reviews.apache.org/r/16265/diff/ > > > Testing > ------- > > % ./build-support/tag-release > == Updating to latest master. > Current branch master is up to date. > == Incrementing snapshot version on master. > [master b8794ae] Incrementing snapshot version from 0.2.0-SNAPSHOT to > 0.3.0-SNAPSHOT. > 1 file changed, 1 insertion(+), 1 deletion(-) > == Creating release-0.2.x branch. > Switched to a new branch 'release-0.2.x' > == Committing updated .auroraversion. > [release-0.2.x b3bab21] aurora-0.2.0 release. > 1 file changed, 1 insertion(+), 1 deletion(-) > == Creating tag 0.2.0. > == Tag created. > > After you've verified that everything looks good, publish the new tag by > running: > git push origin master > git push release-0.2.x master > git push 0.2.0 master > > > Thanks, > > Kevin Sweeney > >
