> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 38
> > <https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38>
> >
> >     Logic does not seem correct here.  Can they both be 'falsey'?
> >     
> >     I'm probably ignorant to style here, but i'm used to 'is not None'.  Is 
> > bool() interchangeable/preferable?

In theory, this is to represent xor (you specify at least a file of hosts or a 
string of hosts, but not both).

This was to convert None/"" to False and "filename_or_hosts" to True, but would 
be happy to move to something else.


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16983/#review32069
-----------------------------------------------------------


On Jan. 16, 2014, 11:59 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16983/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 11:59 a.m.)
> 
> 
> Review request for Aurora and Jonathan Boulle.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix maintenance command documentation and host/filename logic.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 8abb983084933f9320e782dc94f465139d559ebf 
> 
> Diff: https://reviews.apache.org/r/16983/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to