-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16995/#review32096
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/Driver.java
<https://reviews.apache.org/r/16995/#comment60788>

    There's a (very small window) check-then-act race here. Should this be 
synchronized or use checkState(driverRef.compareAndSet(null, driver))?



src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java
<https://reviews.apache.org/r/16995/#comment60786>

    Looks like your sentence was cut off


- Kevin Sweeney


On Jan. 16, 2014, 3 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16995/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 3 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Suman Karumuri.
> 
> 
> Bugs: AURORA-45
>     https://issues.apache.org/jira/browse/AURORA-45
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I've also removed some functions from the Driver interface, since they should 
> be used exclusively by SchedulerLifecycle.
> 
> No test cases were added because 
> SchedulerLifecycleTest#testDefeatedBeforeRegistered() triggered the issue 
> once expectations were altered with the desired new behavior.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Driver.java 
> 5339069a0b932b4f16867335c4b5ee111169742b 
>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
> 247e94065a7f6d9170c2e21ae91b4078c76f0112 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 43f0c4e6b8a75db029e8c61495326a6ab80febb6 
>   src/test/java/org/apache/aurora/scheduler/DriverTest.java 
> c3aa69c1e1bf3e301806fe20fb4d8686ca941e37 
>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
> da7a1678d734ddc7b513b1d0797cb097fa2ee537 
> 
> Diff: https://reviews.apache.org/r/16995/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to