-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17051/#review32163
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/17051/#comment60863>

    need an extra \n here and next



src/main/python/apache/aurora/client/cli/options.py
<https://reviews.apache.org/r/17051/#comment60864>

    isn't there already parse_shards_into?



src/test/python/apache/aurora/client/cli/BUILD
<https://reviews.apache.org/r/17051/#comment60865>

    you can always glob('test_*.py') here if you want.



src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/17051/#comment60866>

    why is this not gen.apache.aurora.constants ACTIVE_STATES?  a similar test 
broke when bill added the THROTTLED state


- Brian Wickman


On Jan. 17, 2014, 4:49 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17051/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 4:49 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Bugs: aurora-53
>     https://issues.apache.org/jira/browse/aurora-53
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add clientv2 implementations of update and list jobs.
> 
> (This was originally planned to also include cancel_update and
> restart, but after testing problems led to splitting out AURORA-42,
> and merges with restart failed, I decided to submit these two,
> and put the others in a subsequent change.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> be156bb52dd48e8e5a0df3ddfb0aef1a815d538e 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 
>   src/main/python/apache/aurora/client/cli/options.py 
> 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 
>   src/main/python/apache/aurora/client/commands/core.py 
> edc57b20f37e6c3d4f13b357b922b9b69091050d 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 97b074488c569c1c92e2bfd69f09ffbd3a827d49 
>   src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> 2985865264a7fd9dd8f59182a4df9e335e210f84 
> 
> Diff: https://reviews.apache.org/r/17051/diff/
> 
> 
> Testing
> -------
> 
> Unit tests all pass; new tests added for the new update command.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to