> On Jan. 21, 2014, 11:40 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 11
> > <https://reviews.apache.org/r/17014/diff/1/?file=425451#file425451line11>
> >
> >     Could this be set to the actual error message? This implementation 
> > seems to swallow it.

I am still thinking that the error message was a stack trace based on the old 
UI and was planning to log it(future diff) instead of showing it to the user. 
This comment made me realize that we actually get a nice error message from the 
thrift end point. Showing the message now. 


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32444
-----------------------------------------------------------


On Jan. 22, 2014, 7:16 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 7:16 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
>     https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to