-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17185/#review32577
-----------------------------------------------------------


eeeek - sorry - this review has been sitting completed in my browser for days, 
but I only just discovered it again after closing a bunch of tabs :-(


src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17185/#comment61475>

    please make usage vs Usage consistent across the board



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17185/#comment61476>

    s/List/Lists/



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17185/#comment61477>

    >1sp



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17185/#comment61478>

    split out



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/17185/#comment61479>

    nit: ^C



src/test/python/apache/aurora/client/cli/BUILD
<https://reviews.apache.org/r/17185/#comment61489>

    bs



src/test/python/apache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/17185/#comment61572>

    configs = [Mock(spec=TaskConfig) for i in range(20)]



src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/17185/#comment61573>

    collapse



src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/17185/#comment61574>

    s/in/it



src/test/python/apache/aurora/client/cli/test_update.py
<https://reviews.apache.org/r/17185/#comment61576>

    configs = [TaskConfig(...) for ...]


- Jonathan Boulle


On Jan. 22, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17185/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Bugs: aurora-53 and aurora-54
>     https://issues.apache.org/jira/browse/aurora-53
>     https://issues.apache.org/jira/browse/aurora-54
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Merged all of the open clientv2 reviews into one unified change.
> 
> - Add clientv2 implementation of "job status" with jobkey wildcard support.
> - Add clientv2 implementations of "job update" and "job list"
> - Add clientv2 implementation of "job restart"
> - Add clientv2 implementation of "job cancel_update"
> - Extract more common options into "options.py".
> - General code cleanup.
> 
> This supersedes the following reviews:
> - https://reviews.apache.org/r/17153/
> - https://reviews.apache.org/r/17051/
> - https://reviews.apache.org/r/17154/
> - https://reviews.apache.org/r/16306/
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 78e54a2233b825ab057a1fb2397c91b50ad1aec0 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> f60d7e9fa5367f43829957e3485e43e76c84bf48 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1b7155409505b46451df072edd196dd7e4c88f1c 
>   src/main/python/apache/aurora/client/commands/core.py 
> 13657c4827072c4f67e0b05034e575616f02338b 
>   src/test/python/apache/aurora/client/cli/BUILD 
> f9ebe0cf626a040aa67654faea07b8902e558282 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 64eb51be32f33de7d67962ff9300e64820a37baf 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 714d5fbeebaaba6cede438c40b3b370d0ee99934 
>   src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> efcf164682a56294863a2aec916b9382a50032b7 
>   src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> 76f954377c154d2a7ab3292a2d772b0566ea06fa 
> 
> Diff: https://reviews.apache.org/r/17185/diff/
> 
> 
> Testing
> -------
> 
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 3 items
> 
> src/test/python/apache/aurora/admin/test_mesos_maintenance.py ...
> 
> =========================== 3 passed in 0.29 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> =========================== 2 passed in 0.30 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ......
> 
> =========================== 6 passed in 0.40 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ......
> 
> =========================== 6 passed in 0.25 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> =========================== 1 passed in 0.22 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ......
> 
> =========================== 6 passed in 0.21 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...............................................
> 
> ===================== 47 passed, 1 skipped in 0.59 seconds 
> =====================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
> src/test/python/apache/aurora/client/api/test_health_check.py ............
> 
> ========================== 20 passed in 0.24 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 26 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ..........................
> 
> ========================== 26 passed in 0.43 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_quota_check.py ......
> 
> =========================== 6 passed in 0.09 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 25 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .....
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 25 passed in 1.42 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 24 items
> 
> src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
> src/test/python/apache/aurora/client/commands/test_create.py ......
> src/test/python/apache/aurora/client/commands/test_diff.py ...
> src/test/python/apache/aurora/client/commands/test_kill.py ...
> src/test/python/apache/aurora/client/commands/test_listjobs.py ..
> src/test/python/apache/aurora/client/commands/test_restart.py ...
> src/test/python/apache/aurora/client/commands/test_status.py ..
> src/test/python/apache/aurora/client/commands/test_update.py ...
> 
> ========================== 24 passed in 1.12 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_run.py .
> 
> =========================== 1 passed in 0.30 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/client/commands/test_ssh.py .
> 
> =========================== 1 passed in 0.28 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 12 items
> 
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
> 
> ========================== 12 passed in 0.23 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 4 items
> 
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
> 
> =========================== 4 passed in 0.22 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/common/test_aurora_job_key.py .
> 
> =========================== 1 passed in 0.05 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/common/test_cluster.py .
> 
> =========================== 1 passed in 0.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 4 items
> 
> src/test/python/apache/aurora/common/test_clusters.py ....
> 
> =========================== 4 passed in 0.11 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 2 items
> 
> src/test/python/apache/aurora/common/test_cluster_option.py ..
> 
> =========================== 2 passed in 0.04 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 3 items
> 
> src/test/python/apache/aurora/common/test_http_signaler.py ...
> 
> =========================== 3 passed in 0.15 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 7 items
> 
> src/test/python/apache/aurora/config/test_base.py .......
> 
> =========================== 7 passed in 1.24 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/config/test_constraint_parsing.py .
> 
> =========================== 1 passed in 0.10 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 6 items
> 
> src/test/python/apache/aurora/config/test_loader.py ......
> 
> =========================== 6 passed in 0.13 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 10 items
> 
> src/test/python/apache/aurora/config/test_thrift.py ..........
> 
> ========================== 10 passed in 1.40 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 4 items
> 
> src/test/python/apache/aurora/executor/test_executor_detector.py ....
> 
> =========================== 4 passed in 0.05 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 4 items
> 
> src/test/python/apache/aurora/executor/test_executor_vars.py ....
> 
> =========================== 4 passed in 0.12 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 5 items
> 
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py .....
> 
> ========================== 5 passed in 17.95 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 2 items
> 
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py ..
> 
> =========================== 2 passed in 0.07 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 3 items
> 
> src/test/python/apache/aurora/executor/common/test_health_checker.py ...
> 
> =========================== 3 passed in 1.41 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/executor/common/test_status_checker.py .
> 
> =========================== 1 passed in 0.05 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.7.2 -- pytest-2.5.1
> collected 1 items
> 
> src/test/python/apache/aurora/executor/common/test_task_info.py .
> 
> =========================== 1 passed in 0.14 seconds 
> ===========================
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/BUILD:all)])
> src.test.python.apache.aurora.admin.mesos_maintenance                         
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator                        
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check                          
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.restarter                            
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client                     
>   .....   SUCCESS
> src.test.python.apache.aurora.client.api.updater                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.binding_helper                           
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.core                            
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.run                             
>   .....   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh                             
>   .....   SUCCESS
> src.test.python.apache.aurora.client.config                                   
>   .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api                         
>   .....   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api                     
>   .....   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key                      
>   .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster                             
>   .....   SUCCESS
> src.test.python.apache.aurora.common.test_cluster_option                      
>   .....   SUCCESS
> src.test.python.apache.aurora.common.test_clusters                            
>   .....   SUCCESS
> src.test.python.apache.aurora.common.test_http_signaler                       
>   .....   SUCCESS
> src.test.python.apache.aurora.config.test_base                                
>   .....   SUCCESS
> src.test.python.apache.aurora.config.test_constraint_parsing                  
>   .....   SUCCESS
> src.test.python.apache.aurora.config.test_loader                              
>   .....   SUCCESS
> src.test.python.apache.aurora.config.test_thrift                              
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox               
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker                  
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker                  
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info                       
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector                      
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars                          
>   .....   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner                    
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to