> On Jan. 27, 2014, 10:18 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, > > line 293 > > <https://reviews.apache.org/r/17372/diff/1/?file=451051#file451051line293> > > > > Does it make sense to special-case the primary-key index here? Seems > > that the taskId index could implement SecondaryIndex (or just rename > > SecondaryIndex to Index).
I like the idea of a consistent API, but i don't think the current SecondaryIndex fits since it implies non-unique keys. Also, a generalized interface might make the fall-back to a full scan awkward. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32894 ----------------------------------------------------------- On Jan. 26, 2014, 9:52 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17372/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2014, 9:52 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-122 > https://issues.apache.org/jira/browse/AURORA-122 > > > Repository: aurora > > > Description > ------- > > Add an abstraction for secondary indices, introduce an index on slave host. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/Preemptor.java > f344cb760cefeceb4a4282bef463a5511cee0f4a > src/main/java/org/apache/aurora/scheduler/base/Tasks.java > 06a19d80483b6949c9851b5d38fe34ac712aa75e > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java > 5ae63e08ed4dbb9beb4ba82d3ac70ebaa13f2e53 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > f418c6ced6d5fc865a904ae1a93199e78abb40de > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > a1c535f1be7f53eb41d469b24e90b8bd36545e3e > > Diff: https://reviews.apache.org/r/17372/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > >
