-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17430/#review33041
-----------------------------------------------------------



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/17430/#comment62250>

    In the future (post-release), i'll ship-block changes like this.  Since 
we're not there yet, and this is a nascent API it LGTM.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/17430/#comment62252>

    This task needs to be different from task1 in some way, otherwise this test 
could deceivingly pass if the two tasks are ever placed into a Set.


- Bill Farner


On Jan. 28, 2014, 8:51 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17430/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 8:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-116
>     https://issues.apache.org/jira/browse/AURORA-116
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Updated test cases to catch this bug.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17430/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build
> gradle run - tested in local UI.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to