> On Feb. 3, 2014, 6:50 p.m., Jonathan Boulle wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, lines 174-181
> > <https://reviews.apache.org/r/17581/diff/3/?file=462163#file462163line174>
> >
> >     hmm, log.error is nonfatal, so you should probably die() in these two 
> > cases

sorry I didn't catch this earlier :-(


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17581/#review33458
-----------------------------------------------------------


On Jan. 31, 2014, 7:52 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17581/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2014, 7:52 p.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-136
>     https://issues.apache.org/jira/browse/AURORA-136
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-108: make set_quota in aurora_admin require explicit units
> 
> set_quota now requies a specific unit (M or G) as input.
> 
> This means that arguments to set_quote should resemble the following:
>     set_quota(<cluster>, <role>, <cpu>, '50M', '20G')
>     set_quota(<cluster>, <role>, <cpu>, '50G', '20G')
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f82900371f8e7566da07beeef4ff0622105c64d6 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 6d191f406a284c60326a49aed32914c81522d4d2 
> 
> Diff: https://reviews.apache.org/r/17581/diff/
> 
> 
> Testing
> -------
> 
> Passes local tests. I could not find a test that tests the quota for the cli 
> client so this patch does not contain an dedicated test case.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to