-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17645/
-----------------------------------------------------------
(Updated Feb. 3, 2014, 9 p.m.)
Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian
Wickman.
Bugs: AURORA-148
https://issues.apache.org/jira/browse/AURORA-148
Repository: aurora
Description
-------
added rollback_on_failure to UpdateConfig
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/updater.py
61e5737cc3cb4d457348cbc1df1f0fc93143de51
src/main/python/apache/aurora/client/api/updater_util.py
623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb
src/main/python/apache/aurora/client/cli/jobs.py
caff6d824d9f43cc9eb0c738ea6bb489321d4669
src/main/python/apache/aurora/client/commands/core.py
8dc4917df7e0d699ee144b4e8fbede6ac05157c2
src/main/python/apache/aurora/config/schema/base.py
1d9f3019d2379e25ab311b45f2851de3b60e263a
src/test/python/apache/aurora/client/api/test_restarter.py
c53824236895d60a61935a0706ad397900aa1148
src/test/python/apache/aurora/client/api/test_updater.py
eabb938ead5b3bab067339ae085dbe2fd262d6a7
Diff: https://reviews.apache.org/r/17645/diff/
Testing
-------
[drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants
src/test/python/apache/aurora/client:all
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
==================================== 2 passed in 0.23 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
==================================== 6 passed in 0.29 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
==================================== 6 passed in 0.12 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/api/test_job_monitor.py .
==================================== 1 passed in 0.09 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
==================================== 6 passed in 0.11 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py
...............................................
============================== 47 passed, 1 skipped in 0.44 seconds
===============================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 20 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ............
==================================== 20 passed in 0.13 seconds
====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 27 items
src/test/python/apache/aurora/client/api/test_updater.py
...........................
==================================== 27 passed in 0.32 seconds
====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
==================================== 6 passed in 0.05 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 25 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .....
src/test/python/apache/aurora/client/cli/test_update.py ...
==================================== 25 passed in 1.12 seconds
====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 24 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ...
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ..
src/test/python/apache/aurora/client/commands/test_update.py ...
==================================== 24 passed in 0.87 seconds
====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
==================================== 1 passed in 0.13 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
==================================== 1 passed in 0.13 seconds
=====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
==================================== 12 passed in 0.11 seconds
====================================
======================================= test session starts
=======================================
platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
==================================== 4 passed in 0.10 seconds
=====================================
src.test.python.apache.aurora.client.api.disambiguator
..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher
..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check
..... SUCCESS
src.test.python.apache.aurora.client.api.restarter
..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client
..... SUCCESS
src.test.python.apache.aurora.client.api.updater
..... SUCCESS
src.test.python.apache.aurora.client.binding_helper
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.commands.core
..... SUCCESS
src.test.python.apache.aurora.client.commands.run
..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
Thanks,
David Robinson
