> On Feb. 3, 2014, 4:34 p.m., Brian Wickman wrote: > > pants, line 20 > > <https://reviews.apache.org/r/17679/diff/1/?file=463687#file463687line20> > > > > why not PANTS_VERSION=$(cat .pantsversion) like before?
This matches the convention in other virtualenv-y scripts, but I don't have strong feelings one way or another. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/#review33543 ----------------------------------------------------------- On Feb. 3, 2014, 3:13 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17679/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 3:13 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Repository: aurora > > > Description > ------- > > Upgrade twitter.common.python to 0.3.0 > > Use the new "pex" utility from twitter.common.python to bootstrap pants > rather than relying on knowledge of the inner workings of > twitter.common.python APIs. I also took the opportunity to refactor the > common "maybe bootstrap a virtualenv" pattern used with some support > tools to use a consistent build-support/NAME.venv pattern. > > > Diffs > ----- > > .gitignore 25114b9fe41747b60de2d176f959ff26571f0062 > build-support/pex PRE-CREATION > build-support/release/make-python-sdists > b2314d72249fee81e434a220a75cbc8588495c5a > pants 229e201b8fa7b069eee4291695ce341318ef976e > rbt 8828ead987ba84ef8d7435b30b7ff99a1d5e20a1 > > Diff: https://reviews.apache.org/r/17679/diff/ > > > Testing > ------- > > Ran ./pants, ./rbt, ./build-support/pex, > ./build-support/release/make-python-sdists from clean and dirty repos. > > ./pants src/test/python:all > > > Thanks, > > Kevin Sweeney > >
