> On Feb. 4, 2014, 2:38 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 130
> > <https://reviews.apache.org/r/17672/diff/1/?file=463517#file463517line130>
> >
> >     Since the HostOffers is fully synchronized, should it rather be static 
> > here?

synchronization and static should be orthogonal, we would not want this to be 
static (avoiding static mutable state is a good thing)


> On Feb. 4, 2014, 2:38 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 360
> > <https://reviews.apache.org/r/17672/diff/1/?file=463517#file463517line360>
> >
> >     s/offers/offer

Fixed.


> On Feb. 4, 2014, 2:38 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 370
> > <https://reviews.apache.org/r/17672/diff/1/?file=463517#file463517line370>
> >
> >     This does not seem to be used.

Line 230, in driverDisconnected().


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17672/#review33560
-----------------------------------------------------------


On Feb. 3, 2014, 8:43 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17672/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 8:43 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-153
>     https://issues.apache.org/jira/browse/AURORA-153
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add indices to OfferQueueImpl to improve resource offer handling performance.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 85bd0a63da122e7daf2f4a12938fef043136f461 
> 
> Diff: https://reviews.apache.org/r/17672/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to