-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17672/#review33625
-----------------------------------------------------------

Ship it!


The logic is much cleaner now. 

Since no new tests are added, what is the code coverage of this class before 
and after this change?


src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java
<https://reviews.apache.org/r/17672/#comment63164>

    Just curious, if we have we considered using a guava Table here? If it is a 
viable alternative, it would be nice to leave a TODO here. 


- Suman Karumuri


On Feb. 4, 2014, 6:41 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17672/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-153
>     https://issues.apache.org/jira/browse/AURORA-153
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add indices to OfferQueueImpl to improve resource offer handling performance.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 85bd0a63da122e7daf2f4a12938fef043136f461 
> 
> Diff: https://reviews.apache.org/r/17672/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to