> On Feb. 4, 2014, 7:22 p.m., Suman Karumuri wrote:
> > The logic is much cleaner now. 
> > 
> > Since no new tests are added, what is the code coverage of this class 
> > before and after this change?

I will check on this and report back.


> On Feb. 4, 2014, 7:22 p.m., Suman Karumuri wrote:
> > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 314
> > <https://reviews.apache.org/r/17672/diff/2/?file=469107#file469107line314>
> >
> >     Just curious, if we have we considered using a guava Table here? If it 
> > is a viable alternative, it would be nice to leave a TODO here.

A great thought, though i don't think it applies cleanly.  My read of Table is 
that it's a two-dimensional mapping as opposed to multiple key-types to 
independently arrive at a value.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17672/#review33625
-----------------------------------------------------------


On Feb. 4, 2014, 6:41 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17672/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 6:41 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-153
>     https://issues.apache.org/jira/browse/AURORA-153
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add indices to OfferQueueImpl to improve resource offer handling performance.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 85bd0a63da122e7daf2f4a12938fef043136f461 
> 
> Diff: https://reviews.apache.org/r/17672/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to