-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17562/#review33635
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/17562/#comment63183>

    How about a binding for GetInfoResult instead?  This will leave us in a 
better position to get rid of @ClusterName in the near future, which would be 
nice.



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/17562/#comment63184>

    Please revert.  This is an anti-pattern, as tests can no longer alter the 
value.  Ideally, the value would be plumbed through a module, but the 
overloaded constructor is a compromise.



src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/17562/#comment63185>

    Thinking about this more, we could save the extra round-trip if the server 
info is embedded in every Response.  APIVersionInterceptor already does 
something like this, embedding the version number in all responses.  What do 
you think about that?


- Bill Farner


On Feb. 4, 2014, 8:15 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17562/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 8:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-120
>     https://issues.apache.org/jira/browse/AURORA-120
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added getInfo API that returns page title and thrift API version.
> 
> Added a TitleController to UI to set the page title. The controller queries 
> the getInfo API to get the clusterName which is now included in the page 
> title.
> 
> Deprecated getVersion API in favor of getInfo to obtain the thrift API 
> version. 
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  822b8b9e3348677ff2f45da2f76ae9a7a96a41b6 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> 2601da9ef64ef91cbf9db9b6f12a8d2cdbb0c297 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 0abd3e737e901f08d18c3ceb55ea2f94847cc2e1 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> a0385e95c8c1fc950f507511377dcebe35f258a7 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 94569f9abfb56c50e67e09cc018484463f9de427 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 644d6e87f5ed44d2705ebbcc6619a727d52c03d8 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 62fc8045f6a5fda234df73452685bd04e3142aaf 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> e88d29732ee8652ede6c7ee13513122086385646 
> 
> Diff: https://reviews.apache.org/r/17562/diff/
> 
> 
> Testing
> -------
> 
> gradle clean build.
> gradle run.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Reply via email to