> On Feb. 4, 2014, 10:28 p.m., Bill Farner wrote:
> > build.gradle, line 25
> > <https://reviews.apache.org/r/17717/diff/2/?file=469367#file469367line25>
> >
> >     Not your issue, but we've fallen out of sort order here.  Mind 
> > re-jiggering these?

reorganized


> On Feb. 4, 2014, 10:28 p.m., Bill Farner wrote:
> > build.gradle, line 312
> > <https://reviews.apache.org/r/17717/diff/2/?file=469367#file469367line312>
> >
> >     Out of curiosity, what files trip if this is false?

All files with the previous headers that do not have 2014 as the year. Its ok 
to skip as checkstyle check is a regex which will verify that it is an apache 
header with any valid YYYY in "Copyright YYYY Apache Software Foundation" where 
license header plugin adds header files for any java files that the header is 
missing in. This will cover all bases on the java side of things


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17717/#review33651
-----------------------------------------------------------


On Feb. 4, 2014, 10:25 p.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17717/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 10:25 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Bill Farner.
> 
> 
> Bugs: AURORA-193
>     https://issues.apache.org/jira/browse/AURORA-193
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> License header cleanup introduced in a584410c.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/Makefile c009890465323c022596aab84553bd00659dba9b 
>   build.gradle 2f355d3528fb4fd5d41ce021ae3330b3af9142f5 
>   config/checkstyle/apache.header PRE-CREATION 
>   config/checkstyle/apache.header.regex PRE-CREATION 
>   config/checkstyle/checkstyle.xml 071e40c52c4f770902fb1c79002198ef35f2cf41 
>   src/main/java/org/apache/aurora/scheduler/events/EventSink.java 
> 4fc425e8a3d6d5931c8923fcca1f4d1d51451dab 
>   
> src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
>  c450276dfaf1f676f63ce55ec37e1d256c993164 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> 940dac4e47bd19e48e8226def245a53ad6f19710 
> 
> Diff: https://reviews.apache.org/r/17717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Reply via email to