-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17734/#review33706
-----------------------------------------------------------


thanks so much for doing this!


src/main/python/apache/aurora/client/api/updater.py
<https://reviews.apache.org/r/17734/#comment63304>

    this newline can be removed.  not sure why it was there to begin with.



src/main/python/apache/aurora/executor/common/task_info.py
<https://reviews.apache.org/r/17734/#comment63306>

    this should stay down with the mesos/psutil/twitter imports.
    
    i understand thrift.* is apache foundation code but the foundational idea 
is that this block should be source imports from within the aurora repository, 
and the next block codegen'ed imports from within the repository (gen.*).  in 
an ideal world we'd name the projects 'aurora' and 'thermos' but both already 
exist as toplevel pypi projects, hence the scope to apache.*
    
    meta-point -- we should consider re-scoping gen.* to apache.gen.* but we 
can take that to the dev list.



src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/17734/#comment63305>

    same



src/test/python/apache/aurora/executor/test_gc_executor.py
<https://reviews.apache.org/r/17734/#comment63307>

    same



src/test/python/apache/aurora/executor/test_thermos_executor.py
<https://reviews.apache.org/r/17734/#comment63308>

    same


- Brian Wickman


On Feb. 5, 2014, 4:30 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17734/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 4:30 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-157
>     https://issues.apache.org/jira/browse/AURORA-157
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-157: Reorder python imports to be consistent
> 
> Move python imports to adhere to the following order:
> - standard library deps
> - apache.* deps
> - gen.* (code generated) deps
> - within-package (.-prefixed) deps
> - third party deps
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/mesos_maintenance.py 
> ab5e912f8878ad97ecc42cfcc27d13cd2336b390 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> c645e9556b50b332cc5a298ceee3d9188a68a727 
>   src/main/python/apache/aurora/client/api/disambiguator.py 
> d163a180610de069615cc3df8343365a5cf895d0 
>   src/main/python/apache/aurora/client/api/health_check.py 
> bd2bcaadb43a34ba4c3b860ab2d42b764feec008 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> dcfae5a8f5921e1c2227c2275ef7b0f3cac678fb 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 2ca417b4fecac2a352113c606141b71d98d90d4b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 46701f21a6f95022755f89656dc0a72264a5800f 
>   src/main/python/apache/aurora/client/api/restarter.py 
> 9a1fcdc14af0f2e0e3300e8128caa0553726e878 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 18f9790714b02ba1aedb2bbe3dff9d49773dda6a 
>   src/main/python/apache/aurora/client/api/updater.py 
> 61e5737cc3cb4d457348cbc1df1f0fc93143de51 
>   src/main/python/apache/aurora/client/base.py 
> 3ccbcf32cf4a8fcbcb6bce5440fc40295db57aa0 
>   src/main/python/apache/aurora/client/bin/aurora_admin.py 
> efbbb6f0fd65971756c20eedab8a1b5e8eba14ba 
>   src/main/python/apache/aurora/client/bin/aurora_client.py 
> fa8b51459935d8678567eb1e69b6a31897a358e0 
>   src/main/python/apache/aurora/client/cli/context.py 
> b54c5a0693546f6c5a37797c2ca993c17bc597ec 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 96f7f7088261eb1b876f4b7214fb808696fb624a 
>   src/main/python/apache/aurora/client/commands/core.py 
> 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 
>   src/main/python/apache/aurora/client/commands/help.py 
> 29002c682959033463145368221762ca538fd133 
>   src/main/python/apache/aurora/client/commands/run.py 
> 0725999cfd2216774478d85ff476634e76bef9cd 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> 4ccf7f528ad89a3482a1282e7f56befab74e465c 
>   src/main/python/apache/aurora/client/config.py 
> d96376a02c1e027cce364891f40ef4c41ffba007 
>   src/main/python/apache/aurora/client/factory.py 
> 6635ec090d03da4c373bf2e7fdfe7c4dc82c8c08 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 532f385bd66fba2993c02fe94ebad19e742cb7d2 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> 4ab6b39175ac7e1914035bdf180c47e84b035748 
>   src/main/python/apache/aurora/common/clusters.py 
> aab7fb6b15ab5aebf61dabd67f06034137fa442c 
>   src/main/python/apache/aurora/config/repl.py 
> d3d239860364745e4de6569a2e50499bd64a42d2 
>   src/main/python/apache/aurora/config/thrift.py 
> 5546a1e91263fb69aa9da62b98083f3b4934d27a 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 1a24b9fdba85bb7e303ff7878e1a239f627c2c8e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 1f3f8309a28584a5457c85840aec6e3db1c86354 
>   src/main/python/apache/aurora/executor/bin/thermos_runner_main.py 
> f35034769ceddfd5eceb85d8f196069c0e40ace9 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 84cfe99e6523203821fb0f59c9b721c84b18c771 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 544c1c10d74f4e06129490b19973d3132b5081fe 
>   src/main/python/apache/aurora/executor/executor_base.py 
> 2b0b5f48db99e176e0ba9186f139428c828ec63d 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> a5294aaaf15fcef51e73f59050c4a4f4e8fcfa31 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 709d8c6997538cf4c0491de3fb18e329b4b82992 
>   src/main/python/apache/aurora/executor/status_manager.py 
> 54b6053f508bd196accdd3c132c29f324920b5cb 
>   src/main/python/apache/aurora/executor/thermos_executor.py 
> edb09a83f5fb69d037b41091757746c55ddd2d2c 
>   src/main/python/apache/aurora/executor/thermos_runner.py 
> 4749e5e1e8913db9433978b8024a588d2ca39858 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 4fee8631f0c6be18f1721d0c1ace622f502b1de9 
>   src/main/python/apache/thermos/bin/thermos.py 
> a80bf1d38c6c929b2cffb56375026c906997a2a7 
>   src/main/python/apache/thermos/bin/thermos_ckpt.py 
> 515abb5d0a618d1d029b5a7b2bf25bec18392e5e 
>   src/main/python/apache/thermos/common/ckpt.py 
> 7dcb07e1f10159b1beed62ff3f7c34fa37a10cac 
>   src/main/python/apache/thermos/config/bin/config_load.py 
> d7728ab6e991e0ef32be81ebef35809df279ce89 
>   src/main/python/apache/thermos/config/loader.py 
> 3c6d673d7fcd63e0828e148917b7e74de4949476 
>   src/main/python/apache/thermos/config/schema_helpers.py 
> 73789ddfc9b30dde75c857e2b5ab573b82154df7 
>   src/main/python/apache/thermos/core/helper.py 
> c9b4837da81a4bbcf963a20b58088e3f2d46647e 
>   src/main/python/apache/thermos/core/inspector.py 
> c9899ef983afb9bde930848bf0d71663a4d19585 
>   src/main/python/apache/thermos/core/muxer.py 
> 2268764919ba3a91802a7bf5b610e611e0edba13 
>   src/main/python/apache/thermos/core/process.py 
> 90fd1da66bd52ac84a47b20275b97447ca80a3f7 
>   src/main/python/apache/thermos/core/runner.py 
> 77f0a92b287608788e5b3552e5e9ab38bbe0417a 
>   src/main/python/apache/thermos/monitoring/disk.py 
> b6140e9b227eb0fb3bea594003b5e481886d0686 
>   src/main/python/apache/thermos/monitoring/garbage.py 
> 9508c13fef48cfba32794009113863918333ed97 
>   src/main/python/apache/thermos/monitoring/monitor.py 
> f11a9128c10ebce5d2ac92b766f0a01b66203c7e 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> 07c6abe2e9aa970df85e5a48cf03cc9f8e2c17c8 
>   src/main/python/apache/thermos/monitoring/resource.py 
> 06e994c9df199fd1d045ca56423248a1d80e7b6b 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> d4115eb96a15aaf9b4eef4f8e4d593b6b00c4810 
>   src/main/python/apache/thermos/observer/http/file_browser.py 
> 2c5332b699605c143068f9181eca32f6bdb18cb5 
>   src/main/python/apache/thermos/observer/http/http_observer.py 
> 190bc296136f94b9a40b2a6ece9e568627de95cc 
>   src/main/python/apache/thermos/observer/http/static_assets.py 
> 040715bf3f951b5e543c543c0c6f836fa68b58ec 
>   src/main/python/apache/thermos/observer/observed_task.py 
> d72ff1837f498348e403bdb27f40f03d79e7fdc9 
>   src/main/python/apache/thermos/observer/task_observer.py 
> eae6b79473cce3e00c4b48ae709a314af78ee969 
>   src/main/python/apache/thermos/testing/runner.py 
> 64de3bd4c0d9d9b7788683fc0dd90a733e7c8830 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 0359098a2e25f68696cd24f9549bc19e73e55ea3 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> d91c3b06005ae6fa0fa7b23429a01fe1af68f178 
> 
> Diff: https://reviews.apache.org/r/17734/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build && ./pants src/test/python:all -vxs 
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to