----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review33708 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/options.py <https://reviews.apache.org/r/17752/#comment63309> you haven't provided %s src/main/python/apache/aurora/client/cli/options.py <https://reviews.apache.org/r/17752/#comment63310> s/INST/INSTANCE/ src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment63311> s/shards/instances src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment63312> the format here isn't right is it? src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment63313> missing def execute() ? src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment63314> missing def execute() ? src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/17752/#comment63316> s/shard/instance/ - Jonathan Boulle On Feb. 5, 2014, 7:27 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17752/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 7:27 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-124 > https://issues.apache.org/jira/browse/aurora-124 > > > Repository: aurora > > > Description > ------- > > Add task noun, supporting "run" and "ssh" verbs. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD > 1019e006998b84ff5757778c05ec39881e44d7ba > src/main/python/apache/aurora/client/cli/__init__.py > 20ecbcf5d3a868f91922244162b516a66d24d32b > src/main/python/apache/aurora/client/cli/options.py > b45af3218e45150a55a4db8d41ae33c320a2c7f6 > src/main/python/apache/aurora/client/cli/task.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 5ba08ad95964ad609e6611d601c765c5c17dae69 > src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION > > Diff: https://reviews.apache.org/r/17752/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (tasknoun)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts > ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 25 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ..... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 25 passed in 1.37 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.30 seconds > =========================== > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > >
