> On Feb. 4, 2014, 9:18 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/api/command_runner.py, line 139
> > <https://reviews.apache.org/r/17724/diff/1/?file=469319#file469319line139>
> >
> >     It's API level, because this is the highest level shared by all of the 
> > distinct code points that could call it. I didn't want to repeat the same 
> > try/catch multiple times in multiple places - in particular, because at 
> > some point, I'd really like to clean up the Pystachio error handling 
> > throughout the client, and having multiple copies of the same thing would 
> > make that more painful.
> >     
> >     The reason that it doesn't generate anything more specific is because 
> > that's already happening. In the current code, you get an error message 
> > saying "TypeError: CommandRunnerTrait[slave_run_directory] is required.". 
> > The problem that I'm trying to fix is that for users, that's not 
> > particularly clear. Now, they'll see "Error executing command: slave 
> > doesn't define necessary parameters, 
> > CommandRunnerTrain[slave_run_directory] is required".
> >

ping?


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17724/#review33674
-----------------------------------------------------------


On Feb. 4, 2014, 4:49 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17724/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 4:49 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-128
>     https://issues.apache.org/jira/browse/aurora-128
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an exception catch to provide a better error message when distributed 
> command runner fails due to un-specified executor parameters in the slave 
> configurations.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> c645e9556b50b332cc5a298ceee3d9188a68a727 
>   src/test/python/apache/aurora/client/commands/test_run.py 
> abcc275d57373038227d3805c16b17b967f92048 
> 
> Diff: https://reviews.apache.org/r/17724/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on the command line.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to