> On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/role.py, line 44 > > <https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44> > > > > Yes, this entire file was meant to be removed. I git mv'ed it to create > > quota.py and it's not in my branch. I'm not sure what to do to fix the > > review - rbt doesn't see any diff, because the file's already gone. > > Mark Chu-Carroll wrote: > Check with rbt diff, and it does *not* include role.py. So this is just a > UI glitch in RBT. > > Jonathan Boulle wrote: > Same story with test_get_quota.py?
Yup. Given that the UI is screwed up, maybe look at the diff using "rbt diff" on the command line? - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 ----------------------------------------------------------- On Feb. 5, 2014, 10:08 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17332/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 10:08 a.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: aurora-107 > https://issues.apache.org/jira/browse/aurora-107 > > > Repository: aurora > > > Description > ------- > > Add a "role" noun. > > Currently, the only operation on roles is getting the quota associated with a > role, > but there are definitely others that can be added later: what packages has a > role created? > How many jobs is a role running? What privileges are associated with a role? > How much > system storage is being used by a role? Etc. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/BUILD > 1019e006998b84ff5757778c05ec39881e44d7ba > src/main/python/apache/aurora/client/cli/__init__.py > 20ecbcf5d3a868f91922244162b516a66d24d32b > src/main/python/apache/aurora/client/cli/options.py > b45af3218e45150a55a4db8d41ae33c320a2c7f6 > src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION > src/test/python/apache/aurora/client/cli/BUILD > 5ba08ad95964ad609e6611d601c765c5c17dae69 > src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION > src/test/python/apache/aurora/client/cli/util.py > cbd544d1e5d0e68bcb94e46e827868e259099d0b > > Diff: https://reviews.apache.org/r/17332/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (user)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ==================================== test session starts > ==================================== > platform darwin -- Python 2.7.2 -- pytest-2.5.1 > collected 20 items > > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_status.py ..... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_get_quota.py ... > > ================================= 20 passed in 0.71 seconds > ================================= > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > >
